wt
5a7fc36722
- Skip older-history loads silently while the connection is down: the trigger previously failed with "not connected", popped the global alert over the timeline and froze scrolling until dismissed. - Accept fast reply-swipe flicks whose end state is clearly leftward even without an intermediate horizontal lock, while scroll-owned touches still never activate the swipe. - Add a seeded-chat UI test mode (launch argument), accessibility identifiers and a LumaUITests target with timeline scroll and reply swipe tests; guard the fix in verify.sh.
132 lines
4.9 KiB
Swift
132 lines
4.9 KiB
Swift
import CoreGraphics
|
|
import XCTest
|
|
@testable import Luma
|
|
|
|
final class MessageReplySwipeTests: XCTestCase {
|
|
func testRightToLeftSwipeReplies() {
|
|
XCTAssertTrue(MessageReplySwipePolicy.shouldReply(
|
|
locked: false,
|
|
translation: CGSize(width: -70, height: 8),
|
|
predictedEndTranslation: CGSize(width: -72, height: 9)
|
|
))
|
|
XCTAssertLessThan(
|
|
MessageReplySwipePolicy.offset(locked: false, translation: CGSize(width: -70, height: 8)),
|
|
0
|
|
)
|
|
}
|
|
|
|
func testLeftToRightSwipeNeverReplies() {
|
|
XCTAssertFalse(MessageReplySwipePolicy.canLock(CGSize(width: 24, height: 10)))
|
|
XCTAssertEqual(
|
|
MessageReplySwipePolicy.offset(locked: false, translation: CGSize(width: 70, height: 8)),
|
|
0
|
|
)
|
|
XCTAssertEqual(
|
|
MessageReplySwipePolicy.offset(locked: true, translation: CGSize(width: 70, height: 8)),
|
|
0
|
|
)
|
|
XCTAssertFalse(MessageReplySwipePolicy.shouldReply(
|
|
locked: false,
|
|
translation: CGSize(width: 70, height: 8),
|
|
predictedEndTranslation: CGSize(width: 72, height: 9)
|
|
))
|
|
}
|
|
|
|
func testVerticalTimelineScrollDoesNotReply() {
|
|
XCTAssertFalse(MessageReplySwipePolicy.shouldReply(
|
|
locked: false,
|
|
translation: CGSize(width: -42, height: 80),
|
|
predictedEndTranslation: CGSize(width: -50, height: 105)
|
|
))
|
|
}
|
|
|
|
func testDiagonalTimelineScrollDoesNotReply() {
|
|
XCTAssertFalse(MessageReplySwipePolicy.shouldReply(
|
|
locked: false,
|
|
translation: CGSize(width: -54, height: 44),
|
|
predictedEndTranslation: CGSize(width: -76, height: 58)
|
|
))
|
|
XCTAssertEqual(
|
|
MessageReplySwipePolicy.offset(locked: false, translation: CGSize(width: -54, height: 44)),
|
|
0
|
|
)
|
|
}
|
|
|
|
func testDiagonalScrollAtOldThresholdDoesNotReply() {
|
|
// width/height ≈ 1.5 passed the old 1.4 dominance and moved bubbles
|
|
// during scrolling; the stricter policy must stay silent.
|
|
XCTAssertFalse(MessageReplySwipePolicy.shouldReply(
|
|
locked: false,
|
|
translation: CGSize(width: -60, height: 40),
|
|
predictedEndTranslation: CGSize(width: -60, height: 40)
|
|
))
|
|
XCTAssertEqual(
|
|
MessageReplySwipePolicy.offset(locked: false, translation: CGSize(width: -60, height: 40)),
|
|
0
|
|
)
|
|
}
|
|
|
|
func testShortSwipeDoesNotReply() {
|
|
XCTAssertFalse(MessageReplySwipePolicy.shouldReply(
|
|
locked: false,
|
|
translation: CGSize(width: -36, height: 4),
|
|
predictedEndTranslation: CGSize(width: -48, height: 5)
|
|
))
|
|
}
|
|
|
|
func testFastHorizontalFlickUsesPredictedEnd() {
|
|
XCTAssertTrue(MessageReplySwipePolicy.shouldReply(
|
|
locked: false,
|
|
translation: CGSize(width: -35, height: 3),
|
|
predictedEndTranslation: CGSize(width: -90, height: 7)
|
|
))
|
|
}
|
|
|
|
func testIndicatorStaysHiddenUntilActivationDistance() {
|
|
XCTAssertEqual(
|
|
MessageReplySwipePolicy.offset(locked: false, translation: CGSize(width: -20, height: 0)),
|
|
0
|
|
)
|
|
XCTAssertLessThan(
|
|
MessageReplySwipePolicy.offset(locked: false, translation: CGSize(width: -24, height: 0)),
|
|
0
|
|
)
|
|
}
|
|
|
|
func testVisualOffsetIsCapped() {
|
|
XCTAssertEqual(
|
|
MessageReplySwipePolicy.offset(locked: true, translation: CGSize(width: -500, height: 0)),
|
|
-MessageReplySwipePolicy.maximumOffset
|
|
)
|
|
}
|
|
|
|
func testCanLockRequiresClearHorizontalStart() {
|
|
XCTAssertTrue(MessageReplySwipePolicy.canLock(CGSize(width: -24, height: 10)))
|
|
XCTAssertFalse(MessageReplySwipePolicy.canLock(CGSize(width: -30, height: 20)))
|
|
XCTAssertFalse(MessageReplySwipePolicy.canLock(CGSize(width: -8, height: 5)))
|
|
XCTAssertFalse(MessageReplySwipePolicy.canLock(CGSize(width: 40, height: 4)))
|
|
}
|
|
|
|
func testCanLockIsUnavailableOnceTheGestureTurnsVertical() {
|
|
// A scroll that arcs left after travelling down must never lock the
|
|
// swipe: the vertical travel already exceeds the lock budget.
|
|
XCTAssertFalse(MessageReplySwipePolicy.canLock(CGSize(width: -30, height: 40)))
|
|
XCTAssertFalse(MessageReplySwipePolicy.canLock(CGSize(width: -80, height: 60)))
|
|
}
|
|
|
|
func testLockedSwipeToleratesVerticalDrift() {
|
|
// Once locked the finger may drift: a 1.17 ratio would be rejected
|
|
// by the 1.6 lock dominance but must still count as a reply swipe.
|
|
XCTAssertTrue(MessageReplySwipePolicy.shouldReply(
|
|
locked: true,
|
|
translation: CGSize(width: -70, height: 60),
|
|
predictedEndTranslation: CGSize(width: -70, height: 60)
|
|
))
|
|
XCTAssertLessThan(
|
|
MessageReplySwipePolicy.offset(locked: true, translation: CGSize(width: -70, height: 60)),
|
|
0
|
|
)
|
|
}
|
|
}
|
|
|