wt/cpp-httplib
1
0
Fork 0
mirror of https://github.com/yhirose/cpp-httplib.git synced 2026-10-01 13:12:40 +07:00
Code Issues Packages Projects Releases Wiki Activity

apply Range only to a 206 response in write_content_with_provider

Browse Source
This commit is contained in:
Sayed Kaif
2026-07-28 13:19:35 +05:30
parent 34b7c846d4
commit 23fef15e07
2 changed files with 49 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/test.cc
+39
View File
@@ -4419,6 +4419,24 @@ protected:
delete data;
});
})
.Get("/streamed-with-range-and-error-status",
[&](const Request & /*req*/, Response &res) {
auto data = new std::string("abcdefg");
res.status = StatusCode::Forbidden_403;
res.set_content_provider(
data->size(), "text/plain",
[data](size_t offset, size_t length, DataSink &sink) {
size_t DATA_CHUNK_SIZE = 4;
const auto &d = *data;
auto out_len =
std::min(static_cast<size_t>(length), DATA_CHUNK_SIZE);
auto ret =
sink.write(&d[static_cast<size_t>(offset)], out_len);
EXPECT_TRUE(ret);
return true;
},
[data](bool /*success*/) { delete data; });
})
.Get("/streamed-cancel",
[&](const Request & /*req*/, Response &res) {
res.set_content_provider(
@@ -5932,6 +5950,27 @@ TEST_F(ServerTest, GetStreamedWithRangeSuffix2) {
EXPECT_EQ(0U, res->body.size());
}
TEST_F(ServerTest, GetStreamedWithRangeAndErrorStatus) {
// The handler answers with a non-2xx status, so `detail::range_error()`
// never validated the ranges and `apply_ranges()` reported the full
// content length. The body must match that header and the content provider
// must not be asked for an offset outside the representation.
auto res = cli_.Get("/streamed-with-range-and-error-status",
Headers{{make_range_header({{3, 5}})}});
ASSERT_TRUE(res) << "Error: " << to_string(res.error());
EXPECT_EQ(StatusCode::Forbidden_403, res->status);
EXPECT_EQ("7", res->get_header_value("Content-Length"));
EXPECT_EQ(false, res->has_header("Content-Range"));
EXPECT_EQ(std::string("abcdefg"), res->body);
auto res2 = cli_.Get("/streamed-with-range-and-error-status",
Headers{{"Range", "bytes=100000-100200"}});
ASSERT_TRUE(res2) << "Error: " << to_string(res2.error());
EXPECT_EQ(StatusCode::Forbidden_403, res2->status);
EXPECT_EQ("7", res2->get_header_value("Content-Length"));
EXPECT_EQ(std::string("abcdefg"), res2->body);
}
TEST_F(ServerTest, GetStreamedWithRangeError) {
auto res =
cli_.Get("/streamed-with-range",