From 3517f92e2f7f3fcdee91149f96179860c16c6348 Mon Sep 17 00:00:00 2001 From: yhirose Date: Fri, 11 Sep 2026 16:16:25 -0400 Subject: [PATCH] ci: remove the temporary windows-without-SSL flaky failure reporter The intermittent failures it was tracking stopped after the graceful drain before close in 8e702d3: no windows-without-SSL test failure on master since 2026-08-09. Drop the reporting step, the issues: write permission it needed, and the run_tests step id that only it used. Claude-Session: https://claude.ai/code/session_0148ZAzsuYRYXkwcA7UFeh95 --- .github/workflows/test.yaml | 30 ------------------------------ 1 file changed, 30 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index a8d317ac..ba7cc50f 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -482,7 +482,6 @@ jobs: runs-on: windows-latest permissions: contents: read - issues: write if: > (github.event_name == 'push') || (github.event_name == 'pull_request' && @@ -592,7 +591,6 @@ jobs: - name: Build ${{ matrix.config.name }} run: cmake --build build --config Release -- /v:m /clp:ShowCommandLine - name: Run tests ${{ matrix.config.name }} - id: run_tests if: ${{ matrix.config.run_tests }} shell: pwsh working-directory: build/test @@ -625,34 +623,6 @@ jobs: } if ($failed) { exit 1 } Write-Host "All shards passed." - - name: Report flaky failure on issue #2533 - if: > - failure() && steps.run_tests.conclusion == 'failure' - && matrix.config.name == 'without SSL' - && github.event_name == 'push' - continue-on-error: true - shell: pwsh - working-directory: build/test - env: - GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} - run: | - $summary = "" - for ($i = 0; $i -lt 4; $i++) { - $log = "shard_${i}.log" - if (Test-Path $log) { - $failedLines = Select-String -Path $log -Pattern "\[ FAILED \]" - if ($failedLines) { - $summary += "**Shard ${i}:**`n" + (($failedLines | ForEach-Object { $_.Line }) -join "`n") + "`n`n" - } - } - } - if (-not $summary) { - Write-Host "No [ FAILED ] line in any shard log; not a test failure. Skipping the report." - exit 0 - } - $runUrl = "$($env:GITHUB_SERVER_URL)/$($env:GITHUB_REPOSITORY)/actions/runs/$($env:GITHUB_RUN_ID)" - $body = "Reoccurred on push: $runUrl`n`nCommit: $($env:GITHUB_SHA)`n`n$summary" - gh issue comment 2533 --repo $env:GITHUB_REPOSITORY --body $body env: VCPKG_ROOT: "C:/vcpkg"