Hash case-insensitive keys in a loop

case_ignore::hash recursed once per character of the key, and trailer
field names from the wire reach it, so a long one could overflow the
stack of a build that keeps the recursion (-O0). Hash in a loop instead,
which gives the same values.
This commit is contained in:
yhirose committed 2026-10-16 16:39:00 -04:00
1 parent 6acdc6255d
commit 82e28aa4f3
2 files changed
+16 -11

No files matched your search

+7 -11
View File
@@ -676,17 +676,13 @@ struct equal_to {
struct hash {
size_t operator()(const std::string &key) const {
return hash_core(key.data(), key.size(), 0);
}
size_t hash_core(const char *s, size_t l, size_t h) const {
return (l == 0) ? h
: hash_core(s + 1, l - 1,
// Unsets the 6 high bits of h, therefore no
// overflow happens
(((std::numeric_limits<size_t>::max)() >> 6) &
h * 33) ^
static_cast<unsigned char>(to_lower(*s)));
size_t h = 0;
for (auto c : key) {
// Unsets the 6 high bits of h, therefore no overflow happens
h = (((std::numeric_limits<size_t>::max)() >> 6) & h * 33) ^
static_cast<unsigned char>(to_lower(c));
}
return h;
}
};