mirror of
https://github.com/yhirose/cpp-httplib.git
synced 2026-10-19 11:19:36 +00:00
Reject userinfo and backslashes in a URL authority
parse_url took http://user@evil.com/ for the host "user@evil.com", where parsers that honour userinfo, or read a backslash as '/', see evil.com. userinfo is not supported, so reject both.
This commit is contained in:
1 parent
eeaae4bc3c
commit
aaccde2122
2 files changed
+14
-5
No files matched your search
+8
-5
@@ -19498,11 +19498,14 @@ TEST(ParseUrlTest, FragmentHandling) {
|
||||
}
|
||||
|
||||
TEST(ParseUrlTest, UserinfoHandling) {
|
||||
// Userinfo with @ but no colon — host includes @
|
||||
detail::UrlComponents uc;
|
||||
ASSERT_TRUE(detail::parse_url("http://user@host.com/path", uc));
|
||||
EXPECT_EQ("user@host.com", uc.host);
|
||||
EXPECT_EQ("/path", uc.path);
|
||||
// userinfo is not supported. Parsers that honour it, or take a backslash for
|
||||
// '/', would see evil.com where the host used to be the whole authority.
|
||||
const char *urls[] = {"http://user@evil.com/", "http://user:pass@evil.com/",
|
||||
"http://evil.com\\@good.com/", "//user@evil.com/x"};
|
||||
for (auto url : urls) {
|
||||
detail::UrlComponents uc;
|
||||
EXPECT_FALSE(detail::parse_url(url, uc)) << url;
|
||||
}
|
||||
}
|
||||
|
||||
TEST(ParseUrlTest, IPv6EdgeCases) {
|
||||
|
||||
Reference in new issue
Block a user