wt/cpp-httplib
1
0 Fork 0
mirror of https://github.com/yhirose/cpp-httplib.git synced 2026-10-21 11:39:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix MakeFileBody/MakeFileProvider tests on Windows

Browse Source 
These tests wrote to a hardcoded "/tmp/" path which does not exist on
Windows, causing the file write to silently fail and the subsequent
make_file_body / make_file_provider call to return zero-sized data.
Use a relative path under the test working directory instead so the
test runs identically on every platform.

Also dump the shard log when a shard's process exits non-zero even
when the gtest summary appears clean (e.g. sanitizer report after
the suite, or assertion-based abort) — previously such failures were
detected only via overall rc and showed no diagnostic output.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
yhiroseandClaude Opus 4.7 committed 2026-04-29 07:33:51 +09:00
1 parent b0866cff8f
commit f50bd311fb
2 files changed
+10 -8
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

test/Makefile
+8 -6
View File
@@ -74,22 +74,24 @@ define run_parallel
$(SETARCH) ./$(1) --gtest_color=yes > $(1)_shard_$$i.log 2>&1 & \ $(SETARCH) ./$(1) --gtest_color=yes > $(1)_shard_$$i.log 2>&1 & \
pids="$$pids $$!"; \ pids="$$pids $$!"; \
done; \ done; \
rc=0; \ exits=""; \
for pid in $$pids; do \ for pid in $$pids; do \
if ! wait $$pid; then rc=1; fi; \ wait $$pid; exits="$$exits $$?"; \
done; \ done; \
for i in $$(seq 0 $$(($(SHARDS) - 1))); do \ i=0; \
for ec in $$exits; do \
log=$(1)_shard_$$i.log; \ log=$(1)_shard_$$i.log; \
if grep -q "\[ PASSED \]" $$log && ! grep -q "\[ FAILED \]" $$log; then \ if grep -q "\[ PASSED \]" $$log && ! grep -q "\[ FAILED \]" $$log && [ $$ec -eq 0 ]; then \
passed=$$(grep "\[ PASSED \]" $$log); \ passed=$$(grep "\[ PASSED \]" $$log); \
echo "Shard $$i: $$passed"; \ echo "Shard $$i: $$passed"; \
else \ else \
echo "=== Shard $$i FAILED ==="; \ echo "=== Shard $$i FAILED (exit=$$ec) ==="; \
cat $$log; \ cat $$log; \
fail=1; \ fail=1; \
fi; \ fi; \
i=$$((i+1)); \
done; \ done; \
if [ $$fail -ne 0 ] || [ $$rc -ne 0 ]; then exit 1; fi; \ if [ $$fail -ne 0 ]; then exit 1; fi; \
echo "All shards passed." echo "All shards passed."
endef endef
test/test.cc
+2 -2
View File
@@ -12276,7 +12276,7 @@ TEST(MultipartFormDataTest, ManyItemsEndToEnd) {
TEST(MultipartFormDataTest, MakeFileProvider) { TEST(MultipartFormDataTest, MakeFileProvider) {
// Verify make_file_provider sends a file's contents correctly. // Verify make_file_provider sends a file's contents correctly.
const std::string file_content(4096, 'Z'); const std::string file_content(4096, 'Z');
const std::string tmp_path = "/tmp/httplib_test_make_file_provider.bin"; const std::string tmp_path = "./httplib_test_make_file_provider.bin";
{ {
std::ofstream ofs(tmp_path, std::ios::binary); std::ofstream ofs(tmp_path, std::ios::binary);
ofs.write(file_content.data(), ofs.write(file_content.data(),
@@ -12331,7 +12331,7 @@ TEST(MultipartFormDataTest, MakeFileProvider) {
TEST(MakeFileBodyTest, Basic) { TEST(MakeFileBodyTest, Basic) {
const std::string file_content(4096, 'Z'); const std::string file_content(4096, 'Z');
const std::string tmp_path = "/tmp/httplib_test_make_file_body.bin"; const std::string tmp_path = "./httplib_test_make_file_body.bin";
{ {
std::ofstream ofs(tmp_path, std::ios::binary); std::ofstream ofs(tmp_path, std::ios::binary);
ofs.write(file_content.data(), ofs.write(file_content.data(),