From 0ad99ce054fd6fa1cb7c18eb656501aba22426be Mon Sep 17 00:00:00 2001
From: Joachim Nilsson <troglobit@gmail.com>
Date: Sat, 29 Feb 2020 16:42:53 +0100
Subject: [PATCH] Fix use-after-close in service.c:redirect(), found by
 Coverity Scan

Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
---
 src/service.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/service.c b/src/service.c
index 07d64fad..4cbbeb3a 100644
--- a/src/service.c
+++ b/src/service.c
@@ -171,7 +171,6 @@ static void redirect(svc_t *svc)
 
 		dup2(fd, STDOUT_FILENO);
 		dup2(fd, STDERR_FILENO);
-		close(fd);
 
 		pid = fork();
 		if (pid == 0) {
@@ -206,6 +205,8 @@ static void redirect(svc_t *svc)
 			execlp("logit", "logit", "-t", tag, "-p", prio, NULL);
 			_exit(0);
 		}
+
+		close(fd);
 	} else if (log_is_debug()) {
 		int fd;