wt/finit
1
0
Fork 0
mirror of https://github.com/troglobit/finit.git synced 2026-09-30 21:13:01 +07:00
Code Issues Packages Projects Releases Wiki Activity

conf: rename remain and manual for what they actually do

Browse Source 
Both keys prompt the question they should be answering.

'remain' decides whether a finished run or task keeps existing: without
it the entry is pruned, so the work re-runs on every runlevel entry,
initctl cannot see it, and its post script never fires.  With it the
entry stays, is not re-run, and gets a teardown when stopped or when it
leaves its runlevels.  That is systemd's RemainAfterExit, and 'remain'
is that name with the informative half cut off.

'manual' says how a service is started but not that it is about
starting at all.

    remain -> remain-after-exit
    manual -> manual-start

Both keep their old spelling as an alias, which they qualify for twice
over, as abbreviations of the canonical name and as the legacy
spellings.

While here, give sec_getbool() the alias argument its string and list
counterparts already take.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
This commit is contained in:
Joachim Wiberg
2026-07-30 15:21:29 +02:00
parent f48f8aacec
commit 13d58ace9f
2 changed files with 59 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/conf-format.sh
+39
View File
@@ -218,3 +218,42 @@ run "echo '}' >> $FINIT_CONF"
run "initctl reload"
retry 'assert_desc "Power failure" pwrfail'
# remain-after-exit keeps a completed task in the service list, so it
# is still visible and can be stopped. The alias must reach the same
# legacy token.
for key in remain-after-exit remain; do
say "$key keeps a completed task visible"
run "echo 'task setup {' > $FINIT_CONF"
run "echo ' description = \"Setup task\"' >> $FINIT_CONF"
run "echo ' runlevel = \"2345\"' >> $FINIT_CONF"
run "echo \" $key = true\" >> $FINIT_CONF"
run "echo ' command = \"/bin/true\"' >> $FINIT_CONF"
run "echo '}' >> $FINIT_CONF"
run "initctl reload"
retry 'assert_desc "Setup task" setup'
done
# manual-start registers the service but does not start it, so both
# spellings must reach the legacy manual:yes token.
for key in manual-start manual; do
say "$key leaves the service stopped until asked"
run "echo 'service service.sh {' > $FINIT_CONF"
run "echo ' description = \"Manual service\"' >> $FINIT_CONF"
run "echo \" $key = true\" >> $FINIT_CONF"
run "echo ' command = \"service.sh\"' >> $FINIT_CONF"
run "echo '}' >> $FINIT_CONF"
run "initctl reload"
retry 'assert_desc "Manual service" service.sh'
assert_num_children 0 service.sh
run "initctl start service.sh"
retry 'assert_num_children 1 service.sh'
# a started service survives the next reload, so clear it before
# the alias pass repeats the "stopped until asked" check
run "initctl stop service.sh"
retry 'assert_num_children 0 service.sh'
done