mirror of
https://github.com/troglobit/finit.git
synced 2026-11-17 19:30:29 +00:00
pidfile: don't let a stopped service claim a PID file
A stopped service with a daemon-owned PID file came back as running
when another process wrote that file, e.g., a container started by
hand:
sudo podman start dash
turned container:dash from stopped to running in initctl, with the
podman PID adopted, moved to the service's cgroup, and its conditions
set. The same happened to a service waiting for its conditions.
The plugin acted on any new or changed PID file, only skipping
services stopping or running scripts, and service_forked() then
cleared the stop.
Only let a service that is starting or running claim its PID file.
Fixes #452
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
(cherry picked from commit a1706e8ebd)
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
This commit is contained in:
4 files changed
+72
No files matched your search
@@ -23,6 +23,10 @@ All relevant changes are documented in this file.
|
||||
|
||||
### Fixes
|
||||
|
||||
- Fix #452: a stopped or waiting service with a daemon-owned PID file
|
||||
was reported as running, with its conditions set, when another
|
||||
process wrote that PID file, e.g., a container started by hand with
|
||||
podman. Found by Mattias Walström
|
||||
- Remove stale daemon-owned (`pid:!`) pidfiles after unclean exits.
|
||||
When a daemon dies via SIGKILL/OOM/segfault, or exits early during
|
||||
startup, its pidfile lingers and can prevent the next instance from
|
||||
|
||||
Reference in new issue
Block a user