mirror of
https://github.com/troglobit/finit.git
synced 2026-11-17 19:30:29 +00:00
pidfile: don't let a stopped service claim a PID file
A stopped service with a daemon-owned PID file came back as running
when another process wrote that file, e.g., a container started by
hand:
sudo podman start dash
turned container:dash from stopped to running in initctl, with the
podman PID adopted, moved to the service's cgroup, and its conditions
set. The same happened to a service waiting for its conditions.
The plugin acted on any new or changed PID file, only skipping
services stopping or running scripts, and service_forked() then
cleared the stop.
Only let a service that is starting or running claim its PID file.
Fixes #452
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
(cherry picked from commit a1706e8ebd)
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
This commit is contained in:
4 files changed
+72
No files matched your search
@@ -109,6 +109,12 @@ static void pidfile_update_conds(char *dir, char *name, uint32_t mask)
|
||||
}
|
||||
|
||||
if (mask & (IN_CLOSE_WRITE | IN_ATTRIB | IN_MODIFY | IN_MOVED_TO)) {
|
||||
/* Only a starting or running service may claim a PID file, issue #452 */
|
||||
if (!svc_is_starting(svc) && !svc_is_running(svc)) {
|
||||
dbg("%s is %s, ignoring %s", nm, svc_status(svc), fn);
|
||||
return;
|
||||
}
|
||||
|
||||
/*
|
||||
* only mark native services as started, the s6 and
|
||||
* systemd style services rely on their respective
|
||||
|
||||
Reference in new issue
Block a user