From 38619966eee3714b6b0ed4b09a694114b31bcd1b Mon Sep 17 00:00:00 2001 From: Joachim Nilsson Date: Thu, 21 Jul 2016 16:35:57 +0200 Subject: [PATCH] Fix interface bring up message NULL ptr deref Signed-off-by: Joachim Nilsson --- finit.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/finit.c b/finit.c index 9c03b5e3..b6291d38 100644 --- a/finit.c +++ b/finit.c @@ -107,12 +107,14 @@ static void networking(void) /* Bring up all 'auto' interfaces */ while (fgets(buf, sizeof(buf), fp)) { - chomp(buf); - strip_line(buf); + char *cmd; - if (!strncmp(buf, "auto", 4)) { - memcpy(buf, "ifup", 4); - run_interactive(buf, "Bringing up interface %s", buf[5]); + chomp(buf); + cmd = strip_line(buf); + + if (!strncmp(cmd, "auto", 4)) { + memcpy(cmd, "ifup", 4); + run_interactive(cmd, "Bringing up interface %s", &cmd[5]); i++; } }