From 3de9643893721b98af5af9346e40e39ea8c0c293 Mon Sep 17 00:00:00 2001 From: Joachim Wiberg Date: Wed, 7 Apr 2021 13:26:56 +0200 Subject: [PATCH] fnwrite(): fix resource leak, found by Coverity Scan Signed-off-by: Joachim Wiberg --- src/util.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/util.c b/src/util.c index 745ff95a..552f9c5b 100644 --- a/src/util.c +++ b/src/util.c @@ -89,6 +89,7 @@ int fnwrite(char *value, char *fmt, ...) char path[256]; va_list ap; FILE *fp; + int rc; if (!value) { errno = EINVAL; @@ -105,11 +106,13 @@ int fnwrite(char *value, char *fmt, ...) /* echo(1) always adds a newline */ if (fputs(value, fp) == EOF || - fputs("\n", fp) == EOF || - fclose(fp)) - return -1; + fputs("\n", fp) == EOF || + fclose(fp) == EOF) + rc = -1; + else + rc = 0; - return 0; + return rc; } /*