From 3ea4be9343e0a2c11210149e1fd698e755d5ba71 Mon Sep 17 00:00:00 2001 From: Joachim Nilsson Date: Wed, 25 Nov 2015 09:30:53 +0100 Subject: [PATCH] Fix NULL ptr dereference causing kernel panic When `service_stop_done()` is called with a `NULL` argument and no dynamic services have been stopped, this regression is triggered. Signed-off-by: Joachim Nilsson --- service.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/service.c b/service.c index 22020b43..d6ea8f5f 100644 --- a/service.c +++ b/service.c @@ -406,7 +406,7 @@ static int service_stop_done(svc_t *svc) plugin_run_hooks(HOOK_SVC_RECONF); /* Reconfigure HW/VLANs/etc here */ /* Finish off by starting/reload modified/new services */ - if (svc->state == SVC_RELOAD_STATE) + if (svc && svc->state == SVC_RELOAD_STATE) service_start_dynamic(); }