From 49bd63994c90f5c57e64d2f6d1020b26ec534e19 Mon Sep 17 00:00:00 2001 From: Joachim Wiberg Date: Mon, 21 Feb 2022 07:02:00 +0100 Subject: [PATCH] Minor refactor - Check all pointers - Declaratons always at top of func/scope - Use established variable nomenclature - Skip useless if() stmt Signed-off-by: Joachim Wiberg --- src/api.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/src/api.c b/src/api.c index 620e2838..d100b679 100644 --- a/src/api.c +++ b/src/api.c @@ -116,17 +116,13 @@ static int do_reload (char *buf, size_t len) { return call(reload, buf, len); } static int do_signal_svc(svc_t *svc, void *user_data) { - if (!svc) - return 1; - - if (!svc_is_running(svc)) + int signo; + + if (!svc || !user_data || !svc_is_running(svc)) return 1; - int sig = *(int *)user_data; - if (kill(svc->pid, sig)) - return 1; - - return 0; + signo = *(int *)user_data; + return !!kill(svc->pid, signo); } static int do_signal(char *buf, size_t len, int sig)