From 500d3017000bbe9954518acafe013f25e806b0b0 Mon Sep 17 00:00:00 2001 From: Joachim Nilsson Date: Wed, 18 Oct 2017 22:45:02 +0200 Subject: [PATCH] tty_unregister(): Fix possible out-of-bounds access, found by Coverity Scan Signed-off-by: Joachim Nilsson --- src/tty.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/tty.c b/src/tty.c index d4bc7621..287a6073 100644 --- a/src/tty.c +++ b/src/tty.c @@ -284,8 +284,9 @@ int tty_unregister(tty_node_t *tty) int i; free(tty->data.cmd); - for (i = 0; tty->data.args[i] && i < TTY_MAX_ARGS; i++) { - free(tty->data.args[i]); + for (i = 0; i < TTY_MAX_ARGS; i++) { + if (tty->data.args[i]) + free(tty->data.args[i]); tty->data.args[i] = NULL; } }