wt/finit
1
0 Fork 0
mirror of https://github.com/troglobit/finit.git synced 2026-10-31 13:00:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: fix use-after-free by switching to strdupa()

Browse Source 
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
This commit is contained in:
Joachim Wiberg committed 2022-05-30 06:53:37 +02:00
1 parent 96ff9c115c
commit 5ef669fb6c
2 files changed
+6 -12
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

test/common/Makefile.am
+2
View File
@@ -1,2 +1,4 @@
noinst_PROGRAMS = serv noinst_PROGRAMS = serv
serv_SOURCES = serv.c serv_SOURCES = serv.c
serv_CPPFLAGS = -D_XOPEN_SOURCE=600 -D_BSD_SOURCE -D_GNU_SOURCE -D_DEFAULT_SOURCE
test/common/serv.c
+4 -12
View File
@@ -21,29 +21,21 @@ static void verify_env(char *arg)
char *replica; char *replica;
char *env; char *env;
key = replica = strdup(arg); key = replica = strdupa(arg);
if (!replica) if (!replica)
err(1, "Failed duplicating arg %s", arg); err(1, "Failed duplicating arg %s", arg);
value = strchr(replica, ':'); value = strchr(replica, ':');
if (!value) { if (!value)
free(replica);
errx(1, "Invalid format of KEY:VALUE arg, missing ':' in %s", replica); errx(1, "Invalid format of KEY:VALUE arg, missing ':' in %s", replica);
}
*(value++) = 0; *(value++) = 0;
env = getenv(key); env = getenv(key);
if (!env) { if (!env)
free(replica);
errx(1, "No '%s' in environment", key); errx(1, "No '%s' in environment", key);
}
if (strcmp(env, value)) { if (strcmp(env, value))
free(replica);
errx(1, "Mismatch, environment '%s' vs expected value '%s'", env, value); errx(1, "Mismatch, environment '%s' vs expected value '%s'", env, value);
}
free(replica);
} }
static void verify_noenv(char *key) static void verify_noenv(char *key)