From 60eccbac31906fdfecc0adcd048c8de0f543053c Mon Sep 17 00:00:00 2001 From: Joachim Nilsson Date: Wed, 13 Dec 2017 12:20:45 +0100 Subject: [PATCH] Refactor, relocate+rename service_enabled() --> svc_enabled() Signed-off-by: Joachim Nilsson --- src/service.c | 25 +------------------------ src/service.h | 1 - src/svc.c | 23 +++++++++++++++++++++++ src/svc.h | 1 + 4 files changed, 25 insertions(+), 25 deletions(-) diff --git a/src/service.c b/src/service.c index e5e6afe9..36ac8721 100644 --- a/src/service.c +++ b/src/service.c @@ -47,29 +47,6 @@ static void svc_set_state(svc_t *svc, svc_state_t new); -/** - * service_enabled - Should the service run? - * @svc: Pointer to &svc_t object - * - * Returns: - * 1, if the service is allowed to run in the current runlevel and the - * user has not manually requested that this service should not run. 0 - * otherwise. - */ -int service_enabled(svc_t *svc) -{ - if (!svc) - return 0; - - if (!svc_in_runlevel(svc, runlevel)) - return 0; - - if (svc_is_removed(svc) || svc_is_blocked(svc)) - return 0; - - return 1; -} - /** * service_timeout_cb - libuev callback wrapper for service timeouts * @w: Watcher @@ -845,7 +822,7 @@ void service_step(svc_t *svc) restart: old_state = svc->state; - enabled = service_enabled(svc); + enabled = svc_enabled(svc); _d("%20s(%4d): %8s %3sabled/%-7s cond:%-4s", svc->cmd, svc->pid, svc_status(svc), enabled ? "en" : "dis", svc_dirtystr(svc), diff --git a/src/service.h b/src/service.h index 2f5c63a3..d907846f 100644 --- a/src/service.h +++ b/src/service.h @@ -30,7 +30,6 @@ void service_runlevel (int newlevel); int service_register (int type, char *line, struct rlimit rlimit[], struct timeval *mtime); void service_unregister (svc_t *svc); -int service_enabled (svc_t *svc); void service_reload_dynamic (void); diff --git a/src/svc.c b/src/svc.c index a2566b70..254845bb 100644 --- a/src/svc.c +++ b/src/svc.c @@ -503,6 +503,29 @@ void svc_prune_bootstrap(void) } } +/** + * svc_enabled - Should the service run? + * @svc: Pointer to &svc_t object + * + * Returns: + * 1, if the service is allowed to run in the current runlevel and the + * user has not manually requested that this service should not run. 0 + * otherwise. + */ +int svc_enabled(svc_t *svc) +{ + if (!svc) + return 0; + + if (!svc_in_runlevel(svc, runlevel)) + return 0; + + if (svc_is_removed(svc) || svc_is_blocked(svc)) + return 0; + + return 1; +} + char *svc_status(svc_t *svc) { switch (svc->state) { diff --git a/src/svc.h b/src/svc.h index 48ef1e98..640fbf50 100644 --- a/src/svc.h +++ b/src/svc.h @@ -173,6 +173,7 @@ void svc_clean_dynamic (void (*cb)(svc_t *)); int svc_clean_bootstrap (svc_t *svc); void svc_prune_bootstrap (void); +int svc_enabled (svc_t *svc); char *svc_status (svc_t *svc); const char *svc_dirtystr (svc_t *svc); int svc_next_id (char *cmd);