mirror of
https://github.com/troglobit/finit.git
synced 2026-11-08 16:11:10 +00:00
libink/dbus: identify the caller behind a broker
On the local bus SO_PEERCRED says who is calling and the kernel is the one saying it. Behind a broker one connection carries every caller, so that credential describes dbus-daemon and nothing else, and every privileged method was refused there, root included. Ask the bus driver instead. libink parks the call and hands us the sender; we ask GetConnectionUnixUser and answer when the reply lands, through the same event loop as everything else. Nothing blocks: blocking in PID 1 is why libuEv exists. That needs calls libink can make on a connection it already has, so it gained those too. Answers are cached, since a bus never reuses a unique name while it runs. Not across a restart though: a new dbus-daemon numbers from scratch and :1.7 becomes somebody else, so the cache goes when the broker does. A sender name too long to key on is refused rather than truncated, two callers sharing a truncated key would share an identity. Privilege is no longer uid 0 alone. The socket is already owned by the --with-group group, so refusing its members every method that changes anything left a wheel user able to open the bus and unable to reboot. Both gates now say the same thing. Group membership needs NSS, which the C library loads with dlopen(), so the lookup is compiled out where Finit is built to link statically. That leaves such a build root-only, which is worth saying out loud rather than leaving to be discovered. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
This commit is contained in:
1 parent
d710a23513
commit
63aabaa6df
17 files changed
+774
-90
No files matched your search
@@ -6,8 +6,10 @@
|
||||
#ifndef LIBINK_MARSHAL_H_
|
||||
#define LIBINK_MARSHAL_H_
|
||||
|
||||
#include <stdarg.h>
|
||||
#include <stddef.h>
|
||||
#include <stdint.h>
|
||||
#include <sys/types.h>
|
||||
|
||||
/* struct link_writer is defined in ink.h (public). Field layout is
|
||||
* "opaque" per the public contract; this file's helpers manipulate
|
||||
@@ -52,4 +54,10 @@ int __r_align (struct link_reader *r, size_t n); /* skip to n-byte boundary */
|
||||
int __r_array_begin(struct link_reader *r, size_t *out_end);
|
||||
int __r_done (const struct link_reader *r);
|
||||
|
||||
/* Marshal varargs into `body` (capacity `cap`) according to `sig`.
|
||||
* Returns the marshalled length, or -1 on overflow or an unsupported
|
||||
* type code. Shared by the synchronous client and the asynchronous
|
||||
* connection-side call. */
|
||||
ssize_t __marshal_va(uint8_t *body, size_t cap, const char *sig, va_list ap);
|
||||
|
||||
#endif /* LIBINK_MARSHAL_H_ */
|
||||
Reference in new issue
Block a user