From 8251f1a422d60d29118c8eb7bc8ab69863437416 Mon Sep 17 00:00:00 2001 From: Joachim Wiberg Date: Sun, 28 Apr 2024 14:40:05 +0200 Subject: [PATCH] Fix derefernce before NULL check Found by Coverity Scan Signed-off-by: Joachim Wiberg --- src/exec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/exec.c b/src/exec.c index cbfd6ee3..21426f39 100644 --- a/src/exec.c +++ b/src/exec.c @@ -138,8 +138,7 @@ int run(char *cmd, char *log) pid = fork(); if (0 == pid) { - char *pfx = *log ? ": " : ""; - char buf[256]; + char *pfx, buf[256]; FILE *pp; int rc; @@ -155,6 +154,7 @@ int run(char *cmd, char *log) if (!pp) _exit(EX_OSERR); + pfx = *log ? ": " : ""; while (fgets(buf, sizeof(buf), pp)) { chomp(buf); logit(LOG_NOTICE, "%s%s%s", log, pfx, buf);