From 8984c655f8bb99595f96f28b621d355a3222c44e Mon Sep 17 00:00:00 2001 From: Joachim Wiberg Date: Mon, 31 Mar 2025 14:16:24 +0200 Subject: [PATCH] cond_get_agg: minor refactor - Use stack instead of heap memory - constify Signed-off-by: Joachim Wiberg --- src/cond.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/cond.c b/src/cond.c index 2b8badea..3d1b06c1 100644 --- a/src/cond.c +++ b/src/cond.c @@ -96,16 +96,16 @@ enum cond_state cond_get(const char *name) enum cond_state cond_get_agg(const char *names) { - static char conds[MAX_COND_LEN]; enum cond_state s = COND_ON; - char *cond; - if (!names) - return COND_ON; + if (names) { + char conds[strlen(names) + 1]; + const char *cond; - strlcpy(conds, names, sizeof(conds)); - for (cond = strtok(conds, ","); s && cond; cond = strtok(NULL, ",")) - s = min(s, cond_get(cond)); + strlcpy(conds, names, sizeof(conds)); + for (cond = strtok(conds, ","); s && cond; cond = strtok(NULL, ",")) + s = min(s, cond_get(cond)); + } return s; }