From 8ce35771c302811e3eb739ad1cba9f8c3389b467 Mon Sep 17 00:00:00 2001 From: Joachim Wiberg Date: Sat, 4 Mar 2023 11:43:57 +0100 Subject: [PATCH] initctl: fix potential memory leak Found by Coverity Scan. Signed-off-by: Joachim Wiberg --- src/initctl.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/initctl.c b/src/initctl.c index 38dfb006..e26fa0b0 100644 --- a/src/initctl.c +++ b/src/initctl.c @@ -1429,10 +1429,16 @@ static void sourcerc(void) while ((line = fparseln(fp, NULL, NULL, NULL, 0))) { char *val; - if ((val = fgetval(line, "FINIT_CONF", "="))) + if ((val = fgetval(line, "FINIT_CONF", "="))) { + if (finit_conf) + free(finit_conf); finit_conf = val; - if ((val = fgetval(line, "FINIT_RCSD", "="))) + } + if ((val = fgetval(line, "FINIT_RCSD", "="))) { + if (finit_rcsd) + free(finit_rcsd); finit_rcsd = val; + } free(line); }