From 929a6e7aace40204e660229e8e63cf2238d18545 Mon Sep 17 00:00:00 2001 From: Joachim Wiberg Date: Tue, 17 May 2022 14:26:24 +0200 Subject: [PATCH] test: fix minor memory leak in test daemon, found by Coverity Signed-off-by: Joachim Wiberg --- test/common/serv.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/test/common/serv.c b/test/common/serv.c index a8ced321..3b5a8257 100644 --- a/test/common/serv.c +++ b/test/common/serv.c @@ -26,16 +26,24 @@ static void verify_env(char *arg) err(1, "Failed duplicating arg %s", arg); value = strchr(replica, ':'); - if (!value) + if (!value) { + free(replica); errx(1, "Invalid format of KEY:VALUE arg, missing ':' in %s", replica); + } *(value++) = 0; env = getenv(key); - if (!env) + if (!env) { + free(replica); errx(1, "No '%s' in environment", key); + } - if (strcmp(env, value)) + if (strcmp(env, value)) { + free(replica); errx(1, "Mismatch, environment '%s' vs expected value '%s'", env, value); + } + + free(replica); } static void verify_noenv(char *key)