From a7ff1a61d5f65a9489e6f422d379cb261a9bc083 Mon Sep 17 00:00:00 2001
From: Joachim Nilsson <troglobit@gmail.com>
Date: Wed, 26 Nov 2014 17:17:47 +0100
Subject: [PATCH] svc_start(): Fix swapped arguments to dup2() and add
 close(fd), descriptor leak.

Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
---
 svc.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/svc.c b/svc.c
index 3a3cb38c..94d7c7c9 100644
--- a/svc.c
+++ b/svc.c
@@ -489,8 +489,9 @@ int svc_start(svc_t *svc)
 
 			fd = open(CONSOLE, O_WRONLY | O_APPEND);
 			if (-1 != fd) {
-				dup2(STDOUT_FILENO, fd);
-				dup2(STDERR_FILENO, fd);
+				dup2(fd, STDOUT_FILENO);
+				dup2(fd, STDERR_FILENO);
+				close(fd);
 			}
 
 			for (i = 0; i < MAX_NUM_SVC_ARGS && args[i]; i++) {