mirror of
https://github.com/troglobit/finit.git
synced 2026-11-02 13:20:32 +00:00
Drop parsing of /proc/cmdline by default, instead use argc + argv[]
For most use-cases the kernel will give Finit its arguments as proper command line args in argc + argv[], like any other program. However, for some users, most notably Alpine Linux, there is a slightly broken initramfs that cannot forward more than one argument using init_args, for such systems you can re-enable the old behavior with a configure switch --enable-kernel-cmdline -- it's not ideal but what can you do. The main reason for removing this feature by default is to support use-cases where Finit runs as the init for container apps that can read /proc -- we do not want them to use the init args from the host. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
This commit is contained in:
1 parent
55e9cb2f58
commit
cc6ffa35fc
4 files changed
+43
-11
No files matched your search
@@ -52,6 +52,10 @@ AC_ARG_ENABLE(auto_reload,
|
||||
AS_HELP_STRING([--enable-auto-reload], [Automatic reload on any .conf change]),,[
|
||||
enable_auto_reload=no])
|
||||
|
||||
AC_ARG_ENABLE(kernel_cmdline,
|
||||
AS_HELP_STRING([--enable-kernel-cmdline], [Parse init args from /proc/cmdline (don't use!)]),,[
|
||||
enable_kernel_cmdline=no])
|
||||
|
||||
AC_ARG_ENABLE(redirect,
|
||||
AS_HELP_STRING([--disable-redirect], [Disable redirection of service output to /dev/null]),,[
|
||||
enable_redirect=yes])
|
||||
@@ -124,6 +128,9 @@ AC_ARG_WITH(watchdog,
|
||||
AS_IF([test "x$enable_auto_reload" = "xyes"], [
|
||||
AC_DEFINE(AUTO_RELOAD, 1, [Finit automatically does `initctl reload` on any .conf change])])
|
||||
|
||||
AS_IF([test "x$enable_kernel_cmdline" = "xyes"], [
|
||||
AC_DEFINE(KERNEL_CMDLINE, 1, [Dumpster diving after init args from /proc/cmdline])])
|
||||
|
||||
AS_IF([test "x$enable_redirect" = "xyes"], [
|
||||
AC_DEFINE(REDIRECT_OUTPUT, 1, [Enable redirection of service output to /dev/null])])
|
||||
|
||||
|
||||
Reference in new issue
Block a user