From cf3d3f6f8e3f1f5288c3887eee99e1e4d632fe8b Mon Sep 17 00:00:00 2001 From: Joachim Wiberg Date: Fri, 5 Mar 2021 10:15:23 +0100 Subject: [PATCH] Properly check return value from mount(2) and display error message Found by Coverity Scan. Signed-off-by: Joachim Wiberg --- src/finit.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/finit.c b/src/finit.c index 42780ffa..f126c2a1 100644 --- a/src/finit.c +++ b/src/finit.c @@ -179,7 +179,8 @@ static void fs_remount_root(int fsckerr) * XXX: Untested, in the initramfs age we should * probably use switch_root instead. */ - rc = mount(SYSROOT, "/", NULL, MS_MOVE, NULL); + if (mount(SYSROOT, "/", NULL, MS_MOVE, NULL)) + _pe("Failed %s / MS_MOVE"); } #endif /* SYSROOT */ @@ -218,8 +219,13 @@ static void fs_init(void) }; size_t i; - for (i = 0; i < NELEMS(fs); i++) - mount(fs[i].spec, fs[i].file, fs[i].type, 0, NULL); + for (i = 0; i < NELEMS(fs); i++) { + int rc; + + rc = mount(fs[i].spec, fs[i].file, fs[i].type, 0, NULL); + if (rc) + _pe("Failed mounting %s on %s", fs[i].spec, fs[i].file); + } } /*