wt/finit
1
0 Fork 0
mirror of https://github.com/troglobit/finit.git synced 2026-11-08 16:11:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix possible NULL ptr deref, found by Coverity Scan

Browse Source 
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
This commit is contained in:
Joachim Wiberg committed 2021-05-31 07:43:29 +02:00
1 parent 754358113f
commit d1d5d39144
1 file changed
+6 -2
Download Patch File Download Diff File Expand all files Collapse all files
src/service.c
+6 -2
View File
@@ -1227,7 +1227,11 @@ int service_register(int type, char *cfg, struct rlimit rlimit[], char *file)
if (tty_parse_args(cmd, &tty)) if (tty_parse_args(cmd, &tty))
return errno; return errno;
len += strlen(tty.cmd) + tty.num + 1; if (tty.cmd)
len += strlen(tty.cmd);
else
len += 3;
len += tty.num + 1;
for (i = 0; i < tty.num; i++) for (i = 0; i < tty.num; i++)
len += strlen(tty.args[i]) + 1; len += strlen(tty.args[i]) + 1;
@@ -1235,7 +1239,7 @@ int service_register(int type, char *cfg, struct rlimit rlimit[], char *file)
if (!line) if (!line)
return errno; return errno;
snprintf(line, len, "%s", tty.cmd); snprintf(line, len, "%s", tty.cmd ? tty.cmd : "tty");
for (i = 0; i < tty.num; i++) { for (i = 0; i < tty.num; i++) {
strlcat(line, " ", len); strlcat(line, " ", len);
strlcat(line, tty.args[i], len); strlcat(line, tty.args[i], len);