Refactor; common nomenclature, ordering, possib. security fix

- Use _PATH_foo for all condition paths, *with* trailing /
- Read condition file first, may not exist, in which case we save time
- Change from libte makepath() to mkpath(), this changes from hard-coded
  0777 perms on all cond dirs to 0755 -- possible security fix

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>

src/cond.c

@@ -45,7 +45,7 @@ const char *cond_path(const char *name)
 	static char path[256];
 	char tmp[MAX_ARG_LEN];
 
-	snprintf(tmp, sizeof(tmp), COND_PATH "/%s", name);
+	snprintf(tmp, sizeof(tmp), _PATH_COND "%s", name);
 
 	return pid_runpath(tmp, path, sizeof(path));
 }
@@ -74,14 +74,14 @@ enum cond_state cond_get_path(const char *path)
 {
 	int cgen, rgen;
 
-	rgen = cond_get_gen(COND_RECONF);
-	if (!rgen)
-		return COND_OFF;
-
 	cgen = cond_get_gen(path);
 	if (!cgen)
 		return COND_OFF;
 
+	rgen = cond_get_gen(_PATH_RECONF);
+	if (!rgen)
+		return COND_OFF;
+
 	return (cgen == rgen) ? COND_ON : COND_FLUX;
 }