wt/finit
1
0 Fork 0
mirror of https://github.com/troglobit/finit.git synced 2026-10-14 10:19:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix possible out-of-bounds write, found by Coverity Scan

Browse Source 
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
This commit is contained in:
Joachim Wiberg committed 2025-12-15 22:37:07 +01:00
1 parent 308f75b209
commit f908c8d43a
1 file changed
+3 -3
Download Patch File Download Diff File Expand all files Collapse all files
src/service.c
+3 -3
View File
@@ -747,7 +747,7 @@ static int service_start(svc_t *svc)
}
} else { /* pid == 0 */
char str[strlen(NOTIFY_PATH) + 32];
char *args[MAX_NUM_SVC_ARGS + 1];
char *args[MAX_NUM_SVC_ARGS + 3];
int status;
if (!svc_is_tty(svc))
@@ -1146,12 +1146,12 @@ int service_stop(svc_t *svc)
svc_set_state(svc, SVC_HALTED_STATE);
}
} else {
char *args[MAX_NUM_SVC_ARGS + 1];
char *args[MAX_NUM_SVC_ARGS + 3];
size_t i = 0, j;
args[i++] = svc->cmd;
/* this handles, e.g., bridge-stop br0 stop */
for (j = 0; j < MAX_NUM_SVC_ARGS - 2; j++) {
for (j = 0; j < MAX_NUM_SVC_ARGS; j++) {
if (!strlen(svc->args[j]))
break;
args[i++] = svc->args[j];