Bump version for v2.2 release.

Signed-off-by: Joachim Nilsson <troglobit@gmail.com>

ChangeLog.md

@@ -1,7 +1,58 @@
 Change Log
 ==========
 
-All notable changes to the project are documented in this file.
+All relevant changes are documented in this file.
+
+
+[2.2][] - 2015-11-23
+--------------------
+
+Lots of fixes to handle static builds, but also fixes for dynamic event
+handling and reconfiguration at runtime.
+
+### Changes
+
+* Upgrade to libuEv v1.2.4, to handle static builds
+* Upgrade to libite (LITE) v1.2.0, to handle static builds
+* Clarify how to select different plugins with the configure script
+* Improve urandom plugin for embedded systems w/o random seed
+* Add `--debug` flag to `initctl`
+* The runlevels listed for services in `initctl show` now hightlight the
+  active runlevel.
+* Clarify in the README and in `initctl help` that the GW event to
+  listen for in service declarations is `GW:UP`
+
+### Fixes
+
+* Build fixes for `configure --disable-inetd`
+* Fixed issue #14: Improved support for static Finit builds
+* Misc. fixes to silence warnings when building a static Finit
+* Default to register services as `SIGHUP`'able, regression in v2.0
+* Call `HOOK_SVC_RECONF` only when all processes have been stopped
+* On reload/reconf we must wait for all services to stop first
+* Only trigger on events that matches the service's specification,
+  fix by Tobias Waldekranz
+
+
+[2.1][] - 2015-10-16
+--------------------
+
+### Changes
+
+* Add hook point for fstab mount failure
+* Set hostname on dynamic reload
+* Upgrade to libite v1.1.1
+
+### Fixes
+
+* Fix service callback coredump checks and simplify callback exit
+* Do not use `-Os` use `-O2` as default optimization level.  Many cross
+  compiler toolchains are known to have problems with `-Os`
+* Do not allow build VERSION to be overloaded by an environment variable
+* Fix too small MAX arguments and too few argments in `svc_t` for
+  reading currently running services with `initctl show`
+* Unblock blocked signals after forking off a child
+
 
 [2.0][] - 2015-09-20
 --------------------
@@ -19,8 +70,8 @@ introduction of an `initctl` tool.
   simply add a `:ID` after the `service` keyword, where `ID` is a unique
   instance number for that service.
 
-        service #1 [2345] /sbin/httpd -f -h /http -p 80   -- Web server
+        service :1 [2345] /sbin/httpd -f -h /http -p 80   -- Web server
-        service #2 [2345] /sbin/httpd -f -h /http -p 8080 -- Old web server
+        service :2 [2345] /sbin/httpd -f -h /http -p 8080 -- Old web server
 
 * Another noteworthy new feature is support for starting/stopping
   services on Netlink events:
@@ -152,6 +203,7 @@ The [libuEv] release.
 
 [1.10][] - 2014-11-27
 ---------------------
+
 Major bug fix release.
 
 ### Changes
@@ -379,7 +431,8 @@ Major bug fix release.
 
 * Initial release
 
-[UNRELEASED]: https://github.com/troglobit/finit/compare/1.12...HEAD
+[UNRELEASED]: https://github.com/troglobit/finit/compare/2.1...HEAD
+[2.1]: https://github.com/troglobit/finit/compare/2.0...2.1
 [2.0]: https://github.com/troglobit/finit/compare/1.12...2.0
 [1.12]: https://github.com/troglobit/finit/compare/1.11...1.12
 [1.11]: https://github.com/troglobit/finit/compare/1.10...1.11

Makefile

@@ -25,8 +25,8 @@
 	install-exec install-data install-dev		\
 	uninstall-exec uninstall-data uninstall-dev
 
-#VERSION    ?= $(shell git tag -l | tail -1)
+#VERSION     = $(shell git tag -l | tail -1)
-VERSION    ?= 2.0
+VERSION     = 2.2
 NAME        = finit
 PKG         = $(NAME)-$(VERSION)
 DEV         = $(NAME)-dev

README.md

@@ -1,5 +1,5 @@
-Finit | Fast & Extensible init for Linux
+Finit ][ Fast & Extensible init for Linux
-========================================
+=========================================
 [![Travis Status]][Travis] [![Coverity Status]][Coverity Scan]
 
 ![Original Finit homepage image](images/finit.jpg "Finit in action!")
@@ -586,21 +586,23 @@ not return until the given command has fully completed.
     Usage: initctl [OPTIONS] <COMMAND>
     
     Options:
+      -d, --debug           Debug initctl (client)
       -v, --verbose         Verbose output
       -h, --help            This help text
     
     Commands:
-            debug           Toggle init daemon debug
+      debug                 Toggle Finit (daemon) debug
-            emit     <EV>   Emit an event: RELOAD, STOP, START, GW
+      emit     <EV>         Emit an event.  Can be a predefined event: RELOAD, STOP,
-                            IFUP:IFNAME, IFDN:IFNAME
+                            START, or a custom string to match the event list in a
-                            IFNAME is the interface name, e.g. eth0
+                            service stanza, e.g: GW:UP, IFUP:IFNAME, IFDN:IFNAME,
-            reload          Reload *.conf in /etc/finit.d/, like SIGHUP
+                            where IFNAME is the interface name, e.g. eth0
-            runlevel <0-9>  Change runlevel: 0 (halt), 6 (reboot)
+      reload                Reload *.conf in /etc/finit.d/ and activate changes
-            start    <JOB#> Start a stopped service
+      runlevel [0-9]        Show or set runlevel: 0 halt, 6 reboot
-            stop     <JOB#> Stop a running service
+      status | show         Show status of services
-            restart  <JOB#> Restart (stop/start) a running service
+      start    <JOB|NAME>   Start stopped job or service
-            reload   <JOB#> Reload (SIGHUP) a running service
+      stop     <JOB|NAME>   Stop/Pause running job or service
-            status | show   List status of all services known to Finit
+      restart  <JOB|NAME>   Restart (stop/start) job or service
+      reload   <JOB|NAME>   Reload (SIGHUP) job or service
       version               Show Finit version
 ```
 
@@ -610,6 +612,11 @@ their command counterparts.  The `reload` command reloads all `*.conf`
 files in `/etc/finit.d/` *and* activates the changes, with `emit RELOAD`
 only the `*.conf` files are reloaded.
 
+**Note:** The `emit STOP` event is more like "prepare" than "stop".
+  Depending on how the service is declared, `<!>` or not, the service
+  may be stopped, or skipped to be be sent `SIGHUP` later when `emit
+  START` is issued.
+
 To achieve the same result as `initctl reload` emit all three events:
 
 ```shell
@@ -643,10 +650,10 @@ started.
 	
 The `emit <EV>` command can also be used to emit custom events.  In
 fact, the event is a simple string.  Declare a list of events in a
-service stanza: `service … <GW,IFUP:eth0>` to reload (`SIGHUP`) a
+service stanza: `service … <GW:UP,IFUP:eth0>` to reload (`SIGHUP`) a
-service when recieving the `"GW"` or `"IFUP:eth0"` strings.  If a
+service when recieving the `"GW:UP"` or `"IFUP:eth0"` strings.  If a
 service cannot handle reload and must be stopped-started, simply add an
-exclamation mark first: `service … <!GW,IFUP:eth0>`.
+exclamation mark first: `service … <!GW:UP,IFUP:eth0>`.
 
 The `<!>` notation to a service stanza can be used empty, then it will
 apply to `reload` and `runlevel` commands.  I.e., when a service's
@@ -706,7 +713,8 @@ switches to configure:
 
 * `--with-plugins=`: List of stock finit plugins to build and install.
   The build system adds `.o` or `.so` extension to the listed plugins
-  depending on the `--enable-static` switch.
+  depending on the `--enable-static` switch.  Hence, list the plugins
+  *without* their extension.
 
 * `--enable-embedded`: Target finit for BusyBox getty and mdev instead
   of a standard Linux distribution with GNU tools and udev.
@@ -754,7 +762,7 @@ First, unpack the archive:
 Then configure, build and install:
 
 ```shell
-    $ ./configure --with-plugins="initctl.so hwclock.so"
+    $ ./configure --with-plugins="initctl hwclock"
     $ make
     CC      finit.o
     CC      conf.o

api.c

@@ -30,6 +30,7 @@
 #include <sys/socket.h>
 #include <sys/un.h>
 
+#include "config.h"
 #include "finit.h"
 #include "conf.h"
 #include "helpers.h"
@@ -107,11 +108,17 @@ static int call(int (*action)(svc_t *), char *buf, size_t len)
 	return result;
 }
 
+static int service_pause(svc_t *svc)
+{
+	return service_stop(svc, SVC_PAUSED_STATE);
+}
+
 static int do_start  (char *buf, size_t len) { return call(service_start,   buf, len); }
-static int do_stop   (char *buf, size_t len) { return call(service_stop,    buf, len); }
+static int do_pause  (char *buf, size_t len) { return call(service_pause,   buf, len); }
 static int do_reload (char *buf, size_t len) { return call(service_reload,  buf, len); }
 static int do_restart(char *buf, size_t len) { return call(service_restart, buf, len); }
 
+#ifndef INETD_DISABLED
 static int do_query_inetd(char *buf, size_t len)
 {
 	int id = 1;
@@ -135,6 +142,7 @@ static int do_query_inetd(char *buf, size_t len)
 
 	return inetd_filter_str(&svc->inetd, buf, len);
 }
+#endif /* !INETD_DISABLED */
 
 typedef struct {
 	char *event;
@@ -255,7 +263,7 @@ static void cb(uev_t *w, void *UNUSED(arg), int UNUSED(events))
 			debug = !debug;
 			break;
 
-		case INIT_CMD_RELOAD:
+		case INIT_CMD_RELOAD: /* 'init q' and 'initctl reload' */
 			service_reload_dynamic();
 			break;
 
@@ -264,7 +272,7 @@ static void cb(uev_t *w, void *UNUSED(arg), int UNUSED(events))
 			break;
 
 		case INIT_CMD_STOP_SVC:
-			result = do_stop(rq.data, sizeof(rq.data));
+			result = do_pause(rq.data, sizeof(rq.data));
 			break;
 
 		case INIT_CMD_RELOAD_SVC:
@@ -275,9 +283,11 @@ static void cb(uev_t *w, void *UNUSED(arg), int UNUSED(events))
 			result = do_restart(rq.data, sizeof(rq.data));
 			break;
 
+#ifndef INETD_DISABLED
 		case INIT_CMD_QUERY_INETD:
 			result = do_query_inetd(rq.data, sizeof(rq.data));
 			break;
+#endif
 
 		case INIT_CMD_EMIT:
 			result = do_handle_emit(rq.data, sizeof(rq.data));

conf.c

@@ -116,18 +116,21 @@ int conf_parse_runlevels(char *runlevels)
 void conf_parse_events(svc_t *svc, char *events)
 {
 	size_t i = 0;
-	char *ptr = events;
+	char *ptr;
-
-	if (!events)
-		return;
 
 	if (!svc) {
 		_e("Invalid service pointer");
 		return;
 	}
 
-	/* First character must be '!' if SIGHUP is not supported. */
+	/* By default we assume UNIX daemons support SIGHUP */
 	svc->sighup = 1;
+
+	if (!events)
+		return;
+
+	/* First character must be '!' if SIGHUP is not supported. */
+	ptr = events;
 	if (ptr[i] == '!') {
 		svc->sighup = 0;
 		ptr++;
@@ -415,6 +418,8 @@ void conf_reload_dynamic(void)
 	while (num--)
 		free(e[num]);
 	free(e);
+
+	set_hostname(&hostname);
 }
 
 int conf_parse_config(void)

configure

@@ -22,6 +22,7 @@ defaults()
         plugindir=${plugindir:="$libdir/$pdir"}
         # The initctl FIFO, should probably be in /run, not /dev
         fifo=${fifo:="/dev/initctl"}
+        random=${random:="/var/lib/urandom/random-seed"}
         conf="finit.conf"
         config=${config:="$sysconfdir/$conf"}
         confdir=${confdir:="finit.d"}
@@ -149,9 +150,9 @@ usage()
         echo "  --with-fifo=FIFO       FIFO for initctl plugin, default '$fifo'"
         echo "  --with-config=CONFIG   Finit CONFIG file, default '\$sysconfdir/$conf'"
         echo "  --with-heading=GREET   Display GREET instead of Finit version at boot"
-        echo "  --with-randomseed=SEED Seed /dev/urandom from file SEED.  On Debian/Ubuntu"
+        echo "  --with-randomseed=SEED Seed /dev/urandom at boot from SEED.  Usually found in"
-        echo "                         systems, set this to /var/lib/urandom/random-seed"
+        echo "                         standard Linux systems at $random"
-        echo "                         Default: none"
+        echo "                         which is also the default.  Requires urandom plugin!"
         echo "  --with-plugins=\"a b c\" Build plugins 'a', 'b' and 'c', either as dynamic .so"
         echo "                         files, or as built-in if --enable-static is given,"
         echo "                         defaults to all plugins.  Exclude extension!"
@@ -345,9 +346,9 @@ fi
 
 echo                                                              >> config.mk
 if [ $debug -eq 1 ]; then
-        echo "CPPFLAGS   += -O0 -g"                               >> config.mk
+        echo "CFLAGS     += -O0 -g"                               >> config.mk
 else
-        echo "CPPFLAGS   += -Os"                                  >> config.mk
+        echo "CFLAGS     += -O2"                                  >> config.mk
 fi
 
 echo                                                              >> config.mk
@@ -375,7 +376,7 @@ fi
 
 if [ x"$libite" != x"" ]; then
         echo "LIBITE      = $libite"                              >> config.mk
-        echo "CFLAGS     += -I\$(LIBITE)/include"                 >> config.mk
+        echo "CPPFLAGS   += -I\$(LIBITE)/include"                 >> config.mk
         echo "LDFLAGS    += -L\$(LIBITE)/lib"                     >> config.mk
         echo "LDLIBS     += -l:libite.so.2"                       >> config.mk
 else
@@ -386,7 +387,7 @@ fi
 
 if [ x"$libuev" != x"" ]; then
         echo "LIBUEV      = $libuev"                              >> config.mk
-        echo "CFLAGS     += -I\$(LIBUEV)/include"                 >> config.mk
+        echo "CPPFLAGS   += -I\$(LIBUEV)/include"                 >> config.mk
         echo "LDFLAGS    += -L\$(LIBUEV)/lib"                     >> config.mk
         echo "LDLIBS     += -l:libuev.so.1"                       >> config.mk
 else
@@ -397,7 +398,7 @@ fi
 
 echo                                                              >> config.mk
 echo "export libdir plugindir incdir"                             >> config.mk
-echo "export CPPFLAGS LDFLAGS LDLIBS STATIC"                      >> config.mk
+echo "export CFLAGS CPPFLAGS LDFLAGS LDLIBS STATIC"               >> config.mk
 
 ##############################################################################
 echo "/* Generated by finit configure script. */"    > config.h

event.c

@@ -140,9 +140,14 @@ int event_cache_if(char *ifname)
 	return entry->updown;
 }
 
-static int validate_events(char *events)
+static int has_events(char *events)
 {
-	return !events || !events[0];
+	return events && events[0];
+}
+
+static int matches_event(char *events, char *event)
+{
+	return strcasestr(events, event) ? 1 : 0;
 }
 
 int event_service_cond(char *events)
@@ -152,7 +157,7 @@ int event_service_cond(char *events)
 	char temp[MAX_ARG_LEN];
 
 	/* No required events, condition satisfied */
-	if (validate_events(events))
+	if (!has_events(events))
 		return cond;
 
 	strlcpy(temp, events, sizeof(temp));
@@ -201,14 +206,16 @@ void event_dispatch(char *msg)
 
 	/* Iterate over svc_t and call service_restart() for event matches */
 	for (svc = svc_iterator(1); svc; svc = svc_iterator(0)) {
-		if (svc->type != SVC_TYPE_SERVICE || validate_events(svc->events))
+		if (svc->type != SVC_TYPE_SERVICE  ||
+		    !service_enabled(svc, 1, NULL) ||
+		    !has_events(svc->events)       ||
+		    !matches_event(svc->events, msg)) {
+			_d("No match for %s in service %s", msg, svc->cmd);
 			continue;
+		}
 
 		if (change == 1) {
-			if (!service_enabled(svc, 1, NULL))
+			_d("%s matches <%s> %s (re)starting ...", msg, svc->events, svc->cmd);
-				continue;
-
-			_d("Got event %s, (re)starting %s ...", svc->events, svc->cmd);
 			if (!svc->pid) {
 				service_start(svc);
 				continue;
@@ -220,12 +227,11 @@ void event_dispatch(char *msg)
 				service_restart(svc);
 		} else { /* change == -1 */
 			if (svc->pid && !event_service_cond(svc->events))
-				service_stop(svc);
+				service_stop(svc, SVC_CONDHALT_STATE);
 		}
 	}
 }
 
-
 /**
  * Local Variables:
  *  version-control: t

finit.c

@@ -71,6 +71,7 @@ static int banner(void)
 
 int main(int argc, char* argv[])
 {
+	int err;
 	uev_ctx_t loop;
 
 	/*
@@ -118,6 +119,10 @@ int main(int argc, char* argv[])
 	/*
 	 * Populate /dev and prepare for runtime events from kernel.
 	 */
+#ifdef EMBEDDED_SYSTEM
+	if (debug)
+		touch("/dev/mdev.log");
+#endif
 	run_interactive(SETUP_DEVFS, "Populating device tree");
 
 	/*
@@ -151,7 +156,13 @@ int main(int argc, char* argv[])
 	plugin_run_hooks(HOOK_ROOTFS_UP);
 
 	umask(0);
-	run("/bin/mount -na");
+	print_desc("Mounting filesystems", NULL);
+
+	err = run("/bin/mount -na");
+	print_result(err);
+	if (err)
+		plugin_run_hooks(HOOK_MOUNT_ERROR);
+
 	run("/sbin/swapon -ea");
 	umask(0022);
 

helpers.c

@@ -84,17 +84,27 @@ int runlevel_get(void)
  */
 char *runlevel_string(int levels)
 {
-	int i, pos = 1;;
+	int i, pos = 1;
-	static char lvl[10] = "[]";
+	static char lvl[20];
+
+	memset(lvl, 0, sizeof(lvl));
+	lvl[0] = '[';
 
 	for (i = 0; i < 10; i++) {
 		if (ISSET(levels, i)) {
+			if (runlevel == i)
+				pos = strlcat(lvl, "\e[1m", sizeof(lvl));
+
 			if (i == 0)
 				lvl[pos++] = 'S';
 			else
 				lvl[pos++] = '0' + i;
+
+			if (runlevel == i)
+				pos = strlcat(lvl, "\e[0m", sizeof(lvl));
 		}
 	}
+
 	lvl[pos++] = ']';
 	lvl[pos]   = 0;
 
@@ -174,27 +184,33 @@ int print_result(int fail)
 	return fail;
 }
 
-#ifndef ENABLE_STATIC
 int getuser(char *username)
 {
+#ifdef ENABLE_STATIC
+	return fgetint("/etc/passwd", "x:\n", username);
+#else
 	struct passwd *usr;
 
 	if (!username || (usr = getpwnam(username)) == NULL)
 		return -1;
 
 	return usr->pw_uid;
+#endif
 }
 
 int getgroup(char *group)
 {
+#ifdef ENABLE_STATIC
+	return fgetint("/etc/group", "x:\n", group);
+#else
 	struct group *grp;
 
 	if ((grp = getgrnam(group)) == NULL)
 		return -1;
 
 	return grp->gr_gid;
-}
 #endif
+}
 
 /* Signal safe sleep ... we get a lot of SIGCHLD at reboot */
 void do_sleep(unsigned int sec)

inetd.c

@@ -212,12 +212,27 @@ void inetd_stop(inetd_t *inetd)
 
 	/* Stop any running service, not allowed anymore. */
 	if (svc->pid)
-		service_stop(svc);
+		service_stop(svc, SVC_WAITING_STATE);
 }
 
 static int getent(char *service, char *proto, struct servent **sv, struct protoent **pv)
 {
+#ifdef ENABLE_STATIC
+	int service_num;
+	static struct servent lfs;
+
+	service_num = fgetint("/etc/services", " \n\t", service);
+	if (service_num > 0) {
+		lfs.s_name = service;
+		lfs.s_port = htons(service_num);
+		lfs.s_proto = NULL;
+		if (!strcmp("tcp", proto) || !strcmp("udp", proto))
+			lfs.s_proto = proto;
+		*sv = &lfs;
+	}
+#else
 	*sv = getservbyname(service, proto);
+#endif
 	if (!*sv) {
 		const char *errstr;
 		static struct servent s;
@@ -238,8 +253,20 @@ static int getent(char *service, char *proto, struct servent **sv, struct protoe
 		*sv = &s;
 	}
 
-	if (pv) {
+	if (pv && (*sv)->s_proto) {
+#ifdef ENABLE_STATIC
+		int proto_num;
+		static struct protoent lfp;
+
+		proto_num = fgetint("/etc/protocols", " \n\t", (*sv)->s_proto);
+		if (proto_num > 0) {
+			lfp.p_name  = proto;
+			lfp.p_proto = proto_num;
+		}
+		*pv = &lfp;
+#else
 		*pv = getprotobyname((*sv)->s_proto);
+#endif
 		if (!*pv) {
 			_e("Cannot find proto %s, skipping.", (*sv)->s_proto);
 			return errno = EINVAL;

initctl.c

@@ -149,26 +149,26 @@ static int show_status(char *UNUSED(arg))
 	}
 
 	for (svc = svc_iterator(1); svc; svc = svc_iterator(0)) {
-		int  inetd = svc_is_inetd(svc);
+		char jobid[10], args[512] = "";
-		char jobid[10], args[80] = "";
-		struct init_request rq = {
-			.magic = INIT_MAGIC,
-			.cmd = INIT_CMD_QUERY_INETD,
-		};
 
 		if (svc_is_unique(svc))
 			snprintf(jobid, sizeof(jobid), "%d", svc->job);
 		else
 			snprintf(jobid, sizeof(jobid), "%d:%d", svc->job, svc->id);
 
-		printf("%-5s  %7s  %-6d  %-9s  ", jobid, svc_status(svc), svc->pid, runlevel_string(svc->runlevels));
+		printf("%-5s  %7s  %-6d  %-18.18s  ", jobid, svc_status(svc), svc->pid, runlevel_string(svc->runlevels));
 		if (!verbose) {
 			printf("%-20s  %s\n", svc->cmd, svc->desc);
 			continue;
 		}
 
-		if (inetd) {
+#ifndef INETD_DISABLED
+		if (svc_is_inetd(svc)) {
 			char *info;
+			struct init_request rq = {
+				.magic = INIT_MAGIC,
+				.cmd = INIT_CMD_QUERY_INETD,
+			};
 
 			snprintf(rq.data, sizeof(rq.data), "%s", jobid);
 			if (do_send(&rq, sizeof(rq))) {
@@ -184,7 +184,10 @@ static int show_status(char *UNUSED(arg))
 			}
 
 			printf("%s %s\n", svc->cmd, info);
-		} else {
+		}
+		else
+#endif /* !INETD_DISABLED */
+		{
 			int i;
 
 			for (i = 1; i < MAX_NUM_SVC_ARGS; i++) {
@@ -203,19 +206,20 @@ static int usage(int rc)
 {
 	fprintf(stderr, "Usage: %s [OPTIONS] <COMMAND>\n\n"
 		"Options:\n"
+		"  -d, --debug           Debug initctl (client)\n"
 		"  -v, --verbose         Verbose output\n"
 		"  -h, --help            This help text\n\n"
 		"Commands:\n"
-		"  debug                 Toggle Finit debug\n"
+		"  debug                 Toggle Finit (daemon) debug\n"
 		"  emit     <EV>         Emit an event.  Can be a predefined event: RELOAD, STOP,\n"
 		"                        START, or a custom string to match the event list in a\n"
-		"                        service stanza, e.g: GW, IFUP:IFNAME, IFDN:IFNAME, where\n"
+		"                        service stanza, e.g: GW:UP, IFUP:IFNAME, IFDN:IFNAME,\n"
-		"                        IFNAME is the interface name, e.g. eth0\n"
+		"                        where IFNAME is the interface name, e.g. eth0\n"
 		"  reload                Reload *.conf in /etc/finit.d/ and activate changes\n"
 		"  runlevel [0-9]        Show or set runlevel: 0 halt, 6 reboot\n"
 		"  status | show         Show status of services\n"
 		"  start    <JOB|NAME>   Start stopped job or service\n"
-		"  stop     <JOB|NAME>   Stop running job or service\n"
+		"  stop     <JOB|NAME>   Stop/Pause running job or service\n"
 		"  restart  <JOB|NAME>   Restart (stop/start) job or service\n"
 		"  reload   <JOB|NAME>   Reload (SIGHUP) job or service\n"
 		"  version               Show Finit version\n\n", __progname);
@@ -241,17 +245,22 @@ int main(int argc, char *argv[])
 	};
 	struct option long_options[] = {
 		{"help",    0, NULL, 'h'},
+		{"debug",   0, NULL, 'd'},
 		{"verbose", 0, NULL, 'v'},
 		{NULL, 0, NULL, 0}
 	};
 
 	verbose = 0;
-	while ((c = getopt_long(argc, argv, "h?v", long_options, NULL)) != EOF) {
+	while ((c = getopt_long(argc, argv, "dh?v", long_options, NULL)) != EOF) {
 		switch(c) {
 		case 'h':
 		case '?':
 			return usage(0);
 
+		case 'd':
+			debug = 1;
+			break;
+
 		case 'v':
 			verbose = 1;
 			break;

plugin.c

@@ -317,11 +317,16 @@ int plugin_load_all(uev_ctx_t *ctx, char *path)
 	closedir(dp);
 #else
 	_d("Finit built statically, not loading plugins from %s ...", path);
+	if (verbose)
+		print_desc("Initializing plugins", NULL);
 #endif	/* ENABLE_STATIC */
 
 	/* Always initialize plugins */
 	init_plugins(ctx);
+
+#ifndef ENABLE_STATIC
 exit:
+#endif
 	if (verbose)
 		print_result(fail);
 

plugin.h

@@ -43,6 +43,7 @@
 typedef enum {
 	/* Bootstrap hooks */
 	HOOK_ROOTFS_UP = 0,
+	HOOK_MOUNT_ERROR,
 	HOOK_BASEFS_UP,
 	HOOK_NETWORK_UP,
 	HOOK_SVC_UP,

plugins/Makefile

@@ -14,7 +14,12 @@ endif
 
 include ../common.mk
 
+ifneq ($(STATIC), 1)
 all: $(PLUGINS)
+else
+all:
+	@true
+endif
 
 clean:
 	-@$(RM) $(PLUGINS)
@@ -22,6 +27,7 @@ clean:
 distclean:
 	-@$(RM) *.o *.so $(JUNK) $(DEPS)
 
+ifneq ($(STATIC), 1)
 install: all
 	@install -d $(DESTDIR)$(plugindir)
 	@for plugin in $(PLUGINS); do \
@@ -35,6 +41,12 @@ uninstall:
 		rm $(DESTDIR)$(plugindir)/$$plugin 2>/dev/null; 	\
 	done
 	-@rmdir $(DESTDIR)$(plugindir) 2>/dev/null
+else
+install:
+	@true
+uninstall:
+	@true
+endif
 
 ifneq ($(MAKECMDGOALS),distclean)
 -include $(DEPS)

plugins/alsa-utils.c

@@ -39,6 +39,7 @@ static void restore(void *UNUSED(arg))
 }
 
 static plugin_t plugin = {
+	.name = __FILE__,
 	.hook[HOOK_BASEFS_UP] = {
 		.cb  = restore
 	},

plugins/bootmisc.c

@@ -24,15 +24,12 @@
 #include <string.h>
 #include <utmp.h>
 
+#include "../config.h"
 #include "../finit.h"
 #include "../helpers.h"
 #include "../plugin.h"
 #include "libite/lite.h"
 
-#ifdef ENABLE_STATIC
-#error This plugin uses getuser(), which relies on dynamically linked GLIBC.  Cannot be built statically!
-#endif
-
 /*
  * Setup standard FHS 2.3 structure in /var, and
  * write runlevel to UTMP, needed by, e.g., printerdrake.
@@ -49,6 +46,7 @@ static void setup(void *UNUSED(arg))
 	makedir("/var/lib",        0755);
 	makedir("/var/lib/misc",   0755);
 	makedir("/var/lib/alarm",  0755);
+	makedir("/var/lib/urandom",0755);
 	makedir("/var/lock",       0755);
 	makedir("/var/log",        0755);
 	makedir("/var/mail",       0755);
@@ -89,7 +87,7 @@ static void setup(void *UNUSED(arg))
 }
 
 static plugin_t plugin = {
-	.name = "bootmisc",
+	.name = __FILE__,
 	.hook[HOOK_BASEFS_UP] = {
 		.cb  = setup
 	},

plugins/dbus.c

@@ -42,6 +42,7 @@ static void setup(void *UNUSED(arg))
 }
 
 static plugin_t plugin = {
+	.name = __FILE__,
 	.hook[HOOK_NETWORK_UP] = {
 		.cb  = setup
 	},

plugins/hwclock.c

@@ -41,6 +41,7 @@ static void restore(void *UNUSED(arg))
 }
 
 static plugin_t plugin = {
+	.name = __FILE__,
 	.hook[HOOK_BASEFS_UP] = {
 		.cb  = restore
 	},

plugins/initctl.c

@@ -42,6 +42,7 @@
 static void parse(void *arg, int fd, int events);
 
 static plugin_t plugin = {
+	.name = __FILE__,
 	.io = {
 		.cb    = parse,
 		.flags = PLUGIN_IO_READ,

plugins/netlink.c

@@ -29,16 +29,20 @@
 #include "../helpers.h"
 #include "../plugin.h"
 
-static int nlmsg_validate(struct nlmsghdr *nlmsg, size_t len)
+static int nlmsg_validate(struct nlmsghdr *nh, size_t len)
 {
-	if (!NLMSG_OK(nlmsg, len))
+	if (!NLMSG_OK(nh, len))
 		return 1;
 
-	if (len < sizeof(struct nlmsghdr))
+	if (nh->nlmsg_type == NLMSG_DONE) {
+		_d("Done with netlink messages.");
 		return 1;
+	}
 
-	if (len < nlmsg->nlmsg_len)
+	if (nh->nlmsg_type == NLMSG_ERROR) {
+		_d("Netlink reports error.");
 		return 1;
+	}
 
 	return 0;
 }
@@ -155,32 +159,28 @@ static void nl_link(struct nlmsghdr *nlmsg)
 static void nl_callback(void *UNUSED(arg), int sd, int UNUSED(events))
 {
 	ssize_t len;
-	static char replybuf[2048];
+	static char buf[4096];
-	struct nlmsghdr *p = (struct nlmsghdr *)replybuf;
+	struct nlmsghdr *nh;
 
-	memset(replybuf, 0, sizeof(replybuf));
+	memset(buf, 0, sizeof(buf));
-	len = recv(sd, replybuf, sizeof(replybuf), 0);
+	len = recv(sd, buf, sizeof(buf), 0);
 	if (len < 0) {
 		if (errno != EINTR)	/* Signal */
 			_pe("recv()");
 		return;
 	}
 
-	for (; len > 0; p = NLMSG_NEXT(p, len)) {
+	for (nh = (struct nlmsghdr *)buf; !nlmsg_validate(nh, len); nh = NLMSG_NEXT(nh, len)) {
-		if (nlmsg_validate(p, len)) {
+		//_d("Well formed netlink message received. type %d ...", nh->nlmsg_type);
-			_e("Packet too small or truncated!");
+		if (nh->nlmsg_type == RTM_NEWROUTE || nh->nlmsg_type == RTM_DELROUTE)
-			return;
+			nl_route(nh);
-		}
-		_d("Well formed netlink message received.");
-
-		if (p->nlmsg_type == RTM_NEWROUTE || p->nlmsg_type == RTM_DELROUTE)
-			nl_route(p);
 		else
-			nl_link(p);
+			nl_link(nh);
 	}
 }
 
 static plugin_t plugin = {
+	.name = __FILE__,
 	.io = {
 		.cb    = nl_callback,
 		.flags = PLUGIN_IO_READ,
@@ -190,20 +190,20 @@ static plugin_t plugin = {
 PLUGIN_INIT(plugin_init)
 {
 	int sd;
-	struct sockaddr_nl addr;
+	struct sockaddr_nl sa;
 
-	sd = socket(PF_NETLINK, SOCK_DGRAM | SOCK_NONBLOCK | SOCK_CLOEXEC, NETLINK_ROUTE);
+	sd = socket(AF_NETLINK, SOCK_RAW | SOCK_NONBLOCK | SOCK_CLOEXEC, NETLINK_ROUTE);
 	if (sd < 0) {
 		_pe("socket()");
 		return;
 	}
 
-	memset(&addr, 0, sizeof(addr));
+	memset(&sa, 0, sizeof(sa));
-	addr.nl_family = AF_NETLINK;
+	sa.nl_family = AF_NETLINK;
-	addr.nl_groups = RTMGRP_IPV4_ROUTE | RTMGRP_LINK;
+	sa.nl_groups = RTMGRP_IPV4_ROUTE | RTMGRP_LINK; // | RTMGRP_NOTIFY | RTMGRP_IPV4_IFADDR;
-	addr.nl_pid    = getpid();
+	sa.nl_pid    = getpid();
 
-	if (bind(sd, (struct sockaddr *)&addr, sizeof(addr)) < 0) {
+	if (bind(sd, (struct sockaddr *)&sa, sizeof(sa)) < 0) {
 		_pe("bind()");
 		close(sd);
 		return;

plugins/resolvconf.c

@@ -66,6 +66,7 @@ static void setup(void *UNUSED(arg))
 }
 
 static plugin_t plugin = {
+	.name = __FILE__,
 	.hook[HOOK_BASEFS_UP] = {
 		.cb  = setup
 	},

plugins/time.c

@@ -62,7 +62,7 @@ static int rfc868(int type)
 }
 
 static plugin_t plugin = {
-	.name  = "time",
+	.name  = "time",	/* Must match the inetd /etc/services entry */
 	.inetd = {
 		.cmd = rfc868
 	}

plugins/tty.c

@@ -37,6 +37,7 @@
 static void watcher(void *arg, int fd, int events);
 
 static plugin_t plugin = {
+	.name = __FILE__,
 	.io = {
 		.cb    = watcher,
 		.flags = PLUGIN_IO_READ,
@@ -45,7 +46,10 @@ static plugin_t plugin = {
 
 static void setup(void)
 {
-	plugin.io.fd = inotify_init1(IN_NONBLOCK);
+	if (plugin.io.fd)
+		close(plugin.io.fd);
+
+	plugin.io.fd = inotify_init1(IN_NONBLOCK | IN_CLOEXEC);
 	if (-1 == plugin.io.fd || inotify_add_watch(plugin.io.fd, "/dev", IN_CREATE | IN_DELETE) < 0)
 		_e("Failed starting TTY watcher: %s", strerror(errno));
 }
@@ -59,9 +63,12 @@ static void watcher(void *UNUSED(arg), int fd, int UNUSED(events))
 
 	while ((len = read(fd, buf, sizeof(buf)))) {
 		if (-1 == len) {
+			if (errno == EINVAL)
+				setup();
 			if (errno == EINTR)
 				continue;
-			break;
+
+			break;	/* Likely EAGAIN */
 		}
 
 		snprintf(name, sizeof(name), "/dev/%s", notified->name);

plugins/urandom.c

@@ -22,29 +22,63 @@
  */
 
 #include <unistd.h>
-#include <sys/types.h>
 #include <sys/stat.h>
+#include <sys/time.h>		/* gettimeofday() */
+#include <sys/types.h>
 
+#include "../config.h"
 #include "../finit.h"
-#include "libite/lite.h"
 #include "../helpers.h"
 #include "../plugin.h"
+#include "libite/lite.h"
 
 static void setup(void *UNUSED(arg))
 {
 #ifdef RANDOMSEED
-	copyfile(RANDOMSEED, "/dev/urandom", 0, 0);
+	if (!fexist(RANDOMSEED)) {
-	unlink(RANDOMSEED);
+		int ret = 1;
+		FILE *fp;
+
+		print_desc("Bootstrapping random seed", NULL);
 		umask(077);
-	copyfile("/dev/urandom", RANDOMSEED, 4096, 0);
+		fp = fopen(RANDOMSEED, "w");
+		if (fp) {
+			int iter = 128;
+			struct timeval tv;
+
+			gettimeofday(&tv, NULL);
+			srandom(tv.tv_sec % 3600);
+			while (iter--) {
+				uint32_t i, prng = random();
+
+				for (i = 0; i < sizeof(prng); i++)
+					fputc((prng >> (i * CHAR_BIT)) & UCHAR_MAX, fp);
+			}
+			ret = fclose(fp);
+		}
+		print_result(ret);
+		umask(0);
+	}
+
+	print_desc("Initializing random number generator", NULL);
+	print_result(512 != copyfile(RANDOMSEED, "/dev/urandom", 0, 0));
+#endif
+}
+
+static void save(void *UNUSED(arg))
+{
+#ifdef RANDOMSEED
+	umask(077);
+	print_desc("Saving random seed", NULL);
+	print_result(512 != copyfile("/dev/urandom", RANDOMSEED, 512, 0));
 	umask(0);
 #endif
 }
 
 static plugin_t plugin = {
-	.hook[HOOK_BASEFS_UP] = {
+	.name = __FILE__,
-		.cb  = setup
+	.hook[HOOK_BASEFS_UP] = { .cb  = setup },
-	},
+	.hook[HOOK_SHUTDOWN]  = { .cb  = save  },
 	.depends = { "bootmisc", }
 };
 

plugins/x11-common.c

@@ -54,6 +54,7 @@ static void setup(void *UNUSED(arg))
 }
 
 static plugin_t plugin = {
+	.name = __FILE__,
 	.hook[HOOK_NETWORK_UP] = {
 		.cb  = setup
 	},

service.c

@@ -41,11 +41,14 @@
 
 #define RESPAWN_MAX    10	        /* Prevent endless respawn of faulty services. */
 
+static int    dyn_stop_cnt = 0;
+
 static int    is_norespawn       (void);
 static void   restart_lost_procs (void);
 static void   svc_dance          (svc_t *svc);
+#ifndef INETD_DISABLED
 static svc_t *find_inetd_svc     (char *path, char *service, char *proto);
-
+#endif
 	
 /**
  * service_bootstrap - Start bootstrap services and tasks
@@ -87,6 +90,8 @@ void service_bootstrap(void)
  */
 svc_cmd_t service_enabled(svc_t *svc, int event, void *arg)
 {
+	svc_cmd_t cmd = SVC_START; /* Default to start, since listed in finit.conf */
+
 	if (!svc) {
 		errno = EINVAL;
 		return SVC_STOP;
@@ -98,9 +103,15 @@ svc_cmd_t service_enabled(svc_t *svc, int event, void *arg)
 	/*
 	 * Event conditions for services are ignored during bootstrap.
 	 */
+	_d("Checking %s runlevel %d and events %s", svc->cmd, runlevel, svc->events);
 	if (runlevel && !event_service_cond(svc->events))
 		return SVC_STOP;
 
+	if (svc->state == SVC_RELOAD_STATE)
+		cmd = SVC_RELOAD;
+	if (svc->state == SVC_PAUSED_STATE)
+		cmd = SVC_STOP;
+
 	/* Is there a service plugin registered? */
 	if (svc->cb) {
 		int   status;
@@ -113,10 +124,8 @@ svc_cmd_t service_enabled(svc_t *svc, int event, void *arg)
 			return SVC_STOP;
 		}
 
-		if (!pid) {
+		if (!pid)
-			status = svc->cb(svc, event, arg);
+			_exit(svc->cb(svc, event, arg));
-			exit(status);
-		}
 
 		if (waitpid(pid, &status, 0) == -1) {
 			_pe("Failed reading status from %s callback", svc->cmd);
@@ -124,11 +133,13 @@ svc_cmd_t service_enabled(svc_t *svc, int event, void *arg)
 		}
 
 		/* Callback normally exits here. */
-		if (WIFEXITED(status))
+		if (WIFEXITED(status)) {
-			return WEXITSTATUS(status);
+			svc_cmd_t tmp = WEXITSTATUS(status);
+			return tmp == SVC_START ? cmd : tmp;
+		}
 
 		/* Check for SEGFAULT or other error ... */
-		if (WCOREDUMP(status))
+		if (WIFSIGNALED(status) && WCOREDUMP(status))
 			_e("Callback to %s crashed!\n", svc->cmd);
 		else
 			_e("Callback to %s did not exit normally!\n", svc->cmd);
@@ -136,8 +147,13 @@ svc_cmd_t service_enabled(svc_t *svc, int event, void *arg)
 		return SVC_STOP;
 	}
 
-	/* No service plugin, default to start, since listed in finit.conf */
+	_d("%s => %s", svc->cmd, (cmd == SVC_START
-	return SVC_START;
+				  ? "SVC_START"
+				  : (cmd == SVC_RELOAD
+				     ? "SVC_RELOAD"
+				     : "SVC_STOP")));
+
+	return cmd;
 }
 
 /* Remember: service_enabled() must be called before calling service_start() */
@@ -278,6 +294,8 @@ int service_start(svc_t *svc)
 			_e("%starting %s: %s", respawn ? "Res" : "S", svc->cmd, buf);
 		}
 
+		sig_unblock();
+
 		if (svc->inetd.cmd)
 			status = svc->inetd.cmd(svc->inetd.type);
 		else
@@ -294,6 +312,7 @@ int service_start(svc_t *svc)
 		exit(status);
 	}
 	svc->pid = pid;
+	svc->state = SVC_RUNNING_STATE;
 
 	if (svc_is_inetd(svc)) {
 		if (svc->inetd.type == SOCK_STREAM)
@@ -315,9 +334,9 @@ int service_start(svc_t *svc)
 	return 0;
 }
 
-int service_stop(svc_t *svc)
+int service_stop(svc_t *svc, int state)
 {
-	int res = 1;
+	int res = 0;
 
 	if (!svc)
 		return 1;
@@ -331,6 +350,12 @@ int service_stop(svc_t *svc)
 	if (SVC_TYPE_SERVICE != svc->type)
 		return 0;
 
+	_d("Service %s state %d, new state %d, sighup %d", svc->cmd, svc->state, state, svc->sighup);
+	if (state == SVC_RELOAD_STATE && svc->sighup)
+		goto exit;
+	if (state == SVC_RESTART_STATE && svc->sighup)
+		return service_reload(svc);
+
 	if (runlevel != 1 && verbose)
 		print_desc("Stopping ", svc->desc);
 
@@ -340,7 +365,8 @@ int service_stop(svc_t *svc)
 	if (runlevel != 1 && verbose)
 		print_result(res);
 exit:
-	svc->pid = 0;
+	if (!res)
+		svc->state = state;
 	svc->restart_counter = 0;
 
 	return res;
@@ -363,8 +389,36 @@ void service_start_dynamic(void)
 	svc_clean_dynamic(service_unregister);
 }
 
+/*
+ * Unless there are services we must collect first (wait for
+ * them to stop), we can call HOOK_SVC_RECONF here.
+ */
+static int service_stop_done(svc_t *svc)
+{
+	if (svc && !svc_is_changed(svc))
+		return 0;
+
+	if (svc && dyn_stop_cnt)
+		dyn_stop_cnt--;
+
+	if (!dyn_stop_cnt) {
+		_d("All disabled/removed services have been stoppped, calling reconf hooks ...");
+		plugin_run_hooks(HOOK_SVC_RECONF); /* Reconfigure HW/VLANs/etc here */
+
+		/* Finish off by starting/reload modified/new services */
+		if (svc->state == SVC_RELOAD_STATE)
+			service_start_dynamic();
+	}
+
+	return 1;
+}
+
 /**
  * service_stop_dynamic - Stop disabled/removed dynamic services
+ *
+ * We call it "stop", but in reality it could be "skip" as well, if the
+ * service supports SIGHUP.  This function is just one step on the road
+ * to reload all modified services.
  */
 void service_stop_dynamic(void)
 {
@@ -372,31 +426,41 @@ void service_stop_dynamic(void)
 
 	_d("Stopping disabled/removed services ...");
 	for (svc = svc_dynamic_iterator(1); svc; svc = svc_dynamic_iterator(0)) {
-		if (svc_is_changed(svc))
+		if (svc_is_changed(svc)) {
-			service_stop(svc);
+			dyn_stop_cnt++;
+			_d("Marking service %s as state %d", svc->cmd, SVC_RELOAD_STATE);
+			service_stop(svc, SVC_RELOAD_STATE);
+		}
 	}
 
-	_d("All disabled/removed services have been stoppped, calling reconf hooks ...");
+	/* Check if we need to collect any services before calling user HOOK */
-	plugin_run_hooks(HOOK_SVC_RECONF); /* Reconfigure HW/VLANs/etc here */
+	service_stop_done(NULL);
 }
 
-/* stop + start
+/**
+ * service_restart - Restart or SIGHUP a process
  *
- * XXX: This should be refactored into a background job AND marked such
+ * Unfortunately we cannot call service_start() here because we must
- *      so that the service monitor doesn't attempt to restart it!
+ * wait for the svc to actually be collected by the service_monitor()
+ * first.  Currently this means that an initctl user will not get
+ * correct feedback when restarting a service.  (Prompt may return
+ * before we've actually started upp the service again.)
+ *
+ * XXX: This should be refactored to let initctl check the sighup
+ *      flag and then to stop+start or reload.
  */
 int service_restart(svc_t *svc)
 {
-	int result = 0;
-
 	if (!svc)
 		return 1;
 
-	result += service_stop(svc);
+	/* Ignore if finit is SIGSTOP'ed */
-	sleep(1);
+	if (is_norespawn())
-	result += service_start(svc);
+		return 0;
 
-	return result;
+	svc->restart_counter = 0;
+
+	return service_stop(svc, SVC_RESTART_STATE);
 }
 
 /**
@@ -415,16 +479,15 @@ int service_reload(svc_t *svc)
 	if (is_norespawn())
 		return 0;
 
-	if (!svc) {
+	if (!svc)
-		_e("Failed, no svc pointer.");
 		return 1;
-	}
 
 	if (svc->pid <= 1) {
 		_d("Bad PID %d for %s, SIGHUP", svc->pid, svc->cmd);
 		svc->pid = 0;
 		return 1;
 	}
+	svc->state = SVC_RUNNING_STATE;
 
 	_d("Sending SIGHUP to PID %d", svc->pid);
 	return kill(svc->pid, SIGHUP);
@@ -445,8 +508,12 @@ void service_reload_dynamic(void)
 	/* Then stop any disabled/removed services and non-reloadable */
 	service_stop_dynamic();
 
-	/* Finish off by starting/reload modified/new services */
+	/*
-	service_start_dynamic();
+	 * Finish off by starting/reloading modified/new services.
+	 * Postponed to service_stop_done() to make sure all services
+	 * are guaranteed to have been stopped before being started
+	 * again.
+	 */
 }
 
 /**
@@ -483,12 +550,12 @@ void service_runlevel(int newlevel)
 				inetd_stop(&svc->inetd);
 			else
 #endif
-				service_stop(svc);
+				service_stop(svc, SVC_HALTED_STATE);
 		}
 
 		/* ... or disabled/removed services from /etc/finit.d/ */
 		if (svc_is_dynamic(svc) && svc_is_changed(svc))
-			service_stop(svc);
+			service_stop(svc, SVC_HALTED_STATE);
 	}
 
 	/* Prev runlevel services stopped, call hooks before starting new runlevel ... */
@@ -762,7 +829,7 @@ int service_register(int type, char *line, time_t mtime, char *username)
 
 void service_unregister(svc_t *svc)
 {
-	service_stop(svc);
+	service_stop(svc, SVC_HALTED_STATE);
 	svc_del(svc);
 }
 
@@ -808,6 +875,10 @@ void service_monitor(pid_t lost)
 		/* No longer running, update books. */
 		svc->pid = 0;
 
+		/* Check if we're still collecting stopped dynamic services */
+		if (service_stop_done(svc))
+			break;
+
 		if (sig_stopped()) {
 			_e("Stopped, not respawning killed processes.");
 			break;
@@ -861,7 +932,7 @@ static void svc_dance(svc_t *svc)
 
 	if (svc->pid) {
 		if (SVC_STOP == cmd)
-			service_stop(svc);
+			service_stop(svc, SVC_HALTED_STATE);
 		else if (SVC_RELOAD == cmd)
 			service_reload(svc);
 	} else {

service.h

@@ -33,7 +33,7 @@ void      service_unregister     (svc_t *svc);
 svc_cmd_t service_enabled	 (svc_t *svc, int event, void *arg);
 
 int	  service_start	         (svc_t *svc);
-int	  service_stop	         (svc_t *svc);
+int	  service_stop	         (svc_t *svc, int state);
 void      service_start_dynamic  (void);
 void      service_stop_dynamic   (void);
 int       service_restart        (svc_t *svc);

sig.c

@@ -96,6 +96,7 @@ void do_shutdown(int sig)
  */
 static void sighup_cb(uev_t *UNUSED(w), void *UNUSED(arg), int UNUSED(events))
 {
+	/* INIT_CMD_RELOAD: 'init q', 'initctl reload', and SIGHUP */
 	service_reload_dynamic();
 }
 
@@ -188,6 +189,7 @@ void sig_unblock(void)
 	struct sigaction sa;
 
 	sigemptyset(&nmask);
+	sigaddset(&nmask, SIGHUP);
 	sigaddset(&nmask, SIGCHLD);
 	sigaddset(&nmask, SIGINT);
 	sigaddset(&nmask, SIGPWR);

svc.h

@@ -46,13 +46,23 @@ typedef enum {
 	SVC_TYPE_INETD		/* Classic inetd service */
 } svc_type_t;
 
+typedef enum {
+	SVC_HALTED_STATE = 0,	/* Not allowed in runlevel, or not enabled. */
+	SVC_WAITING_STATE,	/* Waiting for connection (inetd service)   */
+	SVC_PAUSED_STATE,	/* Stopped/Paused by user started on reload */
+	SVC_CONDHALT_STATE,	/* Not allowed to run atm. event/state lost */
+	SVC_RESTART_STATE,	/* Restarting service waiting to be stopped */
+	SVC_RELOAD_STATE,	/* Reloading services, after .conf changed  */
+	SVC_RUNNING_STATE,	/* Currently running service, see svc->pid  */
+} svc_state_t;
+
 #define FINIT_SHM_ID     0x494E4954  /* "INIT", see ascii(7) */
 #define MAX_ARG_LEN      64
 #define MAX_STR_LEN      64
 #define MAX_USER_LEN     16
 #define MAX_NUM_FDS      64	     /* Max number of I/O plugins */
 #define MAX_NUM_SVC      64	     /* Enough? */
-#define MAX_NUM_SVC_ARGS 16
+#define MAX_NUM_SVC_ARGS 32
 
 /* Default enable for all services, can be stopped by means
  * of issuing an initctl call. E.g.
@@ -63,6 +73,7 @@ typedef struct svc {
 
 	/* Service details */
 	pid_t	       pid;
+	svc_state_t    state;	       /* Paused, Reloading, Restart, Running, ... */
 	svc_type_t     type;
 	time_t	       mtime;	       /* Modification time for .conf from /etc/finit.d/ */
 	int            dirty;	       /* Set if old mtime != new mtime  => reloaded,

tty.h

@@ -25,9 +25,10 @@
 #ifndef FINIT_TTY_H_
 #define FINIT_TTY_H_
 
+#include <limits.h>
 #include "queue.h"		/* BSD sys/queue.h API */
 
-#define EVENT_SIZE ((sizeof(struct inotify_event) + 20))
+#define EVENT_SIZE ((sizeof(struct inotify_event) + NAME_MAX + 1))
 
 typedef struct {
 	char  *name;