mirror of
https://github.com/troglobit/finit.git
synced 2026-09-30 13:02:37 +07:00
Joachim Wiberg
e5040385f5
Two races, both around the post:script Finit runs when it gives up on a service. Finit marks the service crashed before it forks post:script, so the file the test greps for lands a moment later. Waiting for the state is not enough. slay then takes the PID from initctl status, and service_post_script() sets svc->pid to the script's PID, so once Finit has given up the PID reported for the service is the post:script. Killing that takes out the script instead of the service and the file never arrives at all. The guard for this was already there, with a comment describing it, but inside the loop that waits for a PID to appear, so it only covered the case where there was none. A PID that was already there went straight to kill -9. Hence the gcc leg killing once more at lap 13, after Finit had stopped restarting, where clang stopped at 12. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
62 lines
1.1 KiB
Bash
Executable File
62 lines
1.1 KiB
Bash
Executable File
#!/bin/sh
|
|
# Verifies that Finit calls post:script for crashing services
|
|
|
|
set -eu
|
|
|
|
TEST_DIR=$(dirname "$0")
|
|
|
|
test_teardown()
|
|
{
|
|
say "Running test teardown."
|
|
run "rm -f $FINIT_CONF /tmp/post"
|
|
}
|
|
|
|
crashit()
|
|
{
|
|
nm=$1
|
|
|
|
say 'Simulate service crash (kill -9 ..)'
|
|
i=0
|
|
laps=100
|
|
while [ $i -lt $laps ]; do
|
|
i=$((i + 1))
|
|
say "Lap $i/$laps, killing service $nm ..." # we have this, no sleep needed
|
|
if ! run "slay $nm"; then
|
|
break;
|
|
fi
|
|
done
|
|
}
|
|
|
|
test_one()
|
|
{
|
|
type=$1
|
|
shift
|
|
nm=$1
|
|
shift
|
|
args=$*
|
|
|
|
say "Add service stanza in $FINIT_CONF"
|
|
run "echo service log:stderr oncrash:script post:/bin/post.sh $nm $args > $FINIT_CONF"
|
|
|
|
say 'Reload Finit'
|
|
run "initctl reload"
|
|
|
|
if [ "$type" = "sig" ]; then
|
|
retry "assert_num_children 1 $nm"
|
|
run "initctl status $nm"
|
|
crashit "$nm"
|
|
fi
|
|
|
|
retry "assert_status $nm crashed" 500
|
|
retry "assert_file_contains /tmp/post POST" 100
|
|
run "rm -f /tmp/post"
|
|
}
|
|
|
|
# shellcheck source=/dev/null
|
|
. "$TEST_DIR/lib/setup.sh"
|
|
|
|
#run "initctl debug"
|
|
|
|
test_one sig service.sh " -- Test crashing service.sh"
|
|
test_one app serv "-np -c -- Test crashing serv"
|