mirror of
https://github.com/troglobit/finit.git
synced 2026-10-17 10:49:34 +00:00
In 7447192 we dropped support for 'cond set' and 'cond clear' commands
with the motivation they were unsafe and sent the wrong message to the
user. That was true, but mostly because it was too generic and required
the user to call `initctl reload` to apply the changes.
This patch restores the behavior, albeit in a very reduced and simple
format. All conditions set with this command are constrained to the
'usr/...' namespace. No subdirectories are allowed. The argument to
the 'cond set|clear' command is disallowed if it contains '/' or '.'
but anything else is supported, for example:
initctl cond set foo:2
creates a static/oneshot condition in /run/finit/cond/usr/foo:2
These conditions are static and are fully handled by the user. The
initctl command is the recommended, and only supported, way of setting
and clearing usr conditions.
This patch also includes a new plugin, usr.so, which is a very simple
inotify plugin for the /run/finit/cond/usr/ directory. When files are
created or removed here the plugin tells the Finit condition engine to
update and trigger service changes.
For instance, the following service is not started by default at boot:
service <usr/foo> myservice -- MyService
However, as soon as `initctl cond set foo` is called, myservice starts.
Consequently, it is stopped when `initctl cond clr foo` is called.
Another major difference from the original is that this implementation
doesn't send IPC commands to create/delete the conditions. This makes
calling these new commands non-blocking so they can be used very early
in the bootstrap, by plugins, if needed.
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
280 lines
6.2 KiB
C
280 lines
6.2 KiB
C
/* Condition engine (write)
|
|
*
|
|
* Copyright (c) 2015-2017 Tobias Waldekranz <tobias@waldekranz.com>
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
* in the Software without restriction, including without limitation the rights
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
* THE SOFTWARE.
|
|
*/
|
|
|
|
#include <ftw.h>
|
|
#include <libgen.h>
|
|
#include <lite/lite.h>
|
|
#include <stdio.h>
|
|
|
|
#include "finit.h"
|
|
#include "cond.h"
|
|
#include "pid.h"
|
|
#include "service.h"
|
|
|
|
/*
|
|
* The service condition name is constructed from the 'pid/' prefix and
|
|
* the unique NAME:ID tuple that identify each process in Finit. Here
|
|
* are a few examples:
|
|
*
|
|
* The Linux aggregate helper teamd creates PID files in a subdirectory,
|
|
* /run/teamd/lag1.pid:
|
|
*
|
|
* service teamd -f /etc/teamd/lag1.conf -- Aggregate lag1
|
|
*
|
|
* => 'pid/' + 'teamd' + '' = condition <pid/teamd>
|
|
*
|
|
* When you add a second aggrate you need to tell Finit it's a different
|
|
* instance usugin the :ID syntax:
|
|
*
|
|
* service :lag2 teamd -f /etc/teamd/lag2.conf -- Aggregate lag2
|
|
*
|
|
* => 'pid/' + 'teamd' + ':lag2' = condition <pid/teamd:lag2>
|
|
*
|
|
* The next example is for the dbus-daemon. It also use a subdirectory,
|
|
* /run/dbus/pid:
|
|
*
|
|
* service dbus-daemon -- DBus daemon
|
|
*
|
|
* => 'pid/' + 'dbus-daemon' = condition <pid/dbus-daemon>
|
|
*
|
|
* The last example uses lxc-start to start container foo, again in a
|
|
* subdirectory, /run/lxc/foo.pid. We set an ID to be user-friendly to
|
|
* ourselves and override the name usually derivedd using the basename
|
|
* of the path:
|
|
*
|
|
* service name:lxc :foo lxc-start -n foo -F -p /run/lxc/foo.pid -- Container foo
|
|
*
|
|
* => 'pid/' + 'lxc' + ':foo' = condition <pid/lxc:foo>
|
|
*/
|
|
char *mkcond(svc_t *svc, char *buf, size_t len)
|
|
{
|
|
char ident[sizeof(svc->name) + sizeof(svc->id) + 2];
|
|
|
|
snprintf(buf, len, "pid/%s", svc_ident(svc, ident, sizeof(ident)));
|
|
|
|
return buf;
|
|
}
|
|
|
|
static int cond_set_gen(const char *file, unsigned int gen)
|
|
{
|
|
char *ptr, path[256];
|
|
FILE *fp;
|
|
int ret;
|
|
|
|
/* /var/run --> /run symlink may not exist (yet) */
|
|
ptr = pid_runpath(file, path, sizeof(path));
|
|
|
|
fp = fopen(ptr, "w");
|
|
if (!fp)
|
|
return -1;
|
|
|
|
ret = fprintf(fp, "%u\n", gen);
|
|
fclose(fp);
|
|
|
|
return (ret > 0) ? 0 : ret;
|
|
}
|
|
|
|
static void cond_bump_reconf(void)
|
|
{
|
|
unsigned int rgen;
|
|
|
|
/*
|
|
* If %_PATH_RECONF does not exist, cond_get_gen() returns 0
|
|
* meaning that rgen++ is always what we want.
|
|
*/
|
|
rgen = cond_get_gen(_PATH_RECONF);
|
|
rgen++;
|
|
|
|
cond_set_gen(_PATH_RECONF, rgen);
|
|
}
|
|
|
|
static int cond_checkpath(const char *path)
|
|
{
|
|
char buf[MAX_ARG_LEN], *dir;
|
|
|
|
strlcpy(buf, path, sizeof(buf));
|
|
dir = dirname(buf);
|
|
if (!dir) {
|
|
_e("Invalid path '%s' for condition", path);
|
|
return 1;
|
|
}
|
|
|
|
if (mkpath(dir, 0755) && errno != EEXIST) {
|
|
_pe("Failed creating dir '%s' for condition '%s'", dir, path);
|
|
return 1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
int cond_set_path(const char *path, enum cond_state new)
|
|
{
|
|
enum cond_state old;
|
|
unsigned int rgen;
|
|
|
|
_d("%s", path);
|
|
|
|
rgen = cond_get_gen(_PATH_RECONF);
|
|
if (!rgen) {
|
|
_e("Unable to read configuration generation (%s)", path);
|
|
return -1;
|
|
}
|
|
|
|
old = cond_get_path(path);
|
|
|
|
switch (new) {
|
|
case COND_ON:
|
|
if (cond_checkpath(path))
|
|
return 0;
|
|
cond_set_gen(path, rgen);
|
|
break;
|
|
|
|
case COND_OFF:
|
|
if (unlink(path) && errno != ENOENT)
|
|
_pe("Failed removing condition '%s'", path);
|
|
break;
|
|
|
|
default:
|
|
_e("Invalid condition state");
|
|
return 0;
|
|
}
|
|
|
|
return new != old;
|
|
}
|
|
|
|
/* Should only be used by cond_set*(), cond_clear(), and usr plugin! */
|
|
void cond_update(const char *name)
|
|
{
|
|
svc_t *svc, *iter = NULL;
|
|
|
|
_d("%s", name);
|
|
for (svc = svc_iterator(&iter, 1); svc; svc = svc_iterator(&iter, 0)) {
|
|
if (!svc_has_cond(svc) || !cond_affects(name, svc->cond))
|
|
continue;
|
|
|
|
_d("%s: match <%s> %s(%s)", name ?: "nil", svc->cond, svc->desc, svc->cmd);
|
|
service_step(svc);
|
|
}
|
|
}
|
|
|
|
void cond_set(const char *name)
|
|
{
|
|
_d("%s", name);
|
|
if (string_compare(name, "nop"))
|
|
return;
|
|
|
|
if (!cond_set_path(cond_path(name), COND_ON))
|
|
return;
|
|
|
|
cond_update(name);
|
|
}
|
|
|
|
void cond_set_oneshot(const char *name)
|
|
{
|
|
const char *path;
|
|
|
|
if (string_compare(name, "nop"))
|
|
return;
|
|
|
|
path = cond_path(name);
|
|
_d("%s => %s", name, path);
|
|
|
|
if (cond_checkpath(path))
|
|
return;
|
|
|
|
if (symlink(_PATH_RECONF, path) && errno != EEXIST)
|
|
_pe("Failed creating onshot cond %s", name);
|
|
cond_update(name);
|
|
}
|
|
|
|
void cond_clear(const char *name)
|
|
{
|
|
_d("%s", name);
|
|
if (string_compare(name, "nop"))
|
|
return;
|
|
|
|
if (!cond_set_path(cond_path(name), COND_OFF))
|
|
return;
|
|
|
|
cond_update(name);
|
|
}
|
|
|
|
void cond_reload(void)
|
|
{
|
|
_d("");
|
|
|
|
cond_bump_reconf();
|
|
}
|
|
|
|
static int reassert(const char *fpath, const struct stat *sb, int tflg, struct FTW *ftw)
|
|
{
|
|
char *nm;
|
|
|
|
if (ftw->level == 0)
|
|
return 1;
|
|
|
|
if (tflg != FTW_F)
|
|
return 0;
|
|
|
|
nm = strstr((char *)fpath, COND_BASE);
|
|
if (!nm) {
|
|
_e("Incorrect condtion path %s, cannot reassert", fpath);
|
|
return 1;
|
|
}
|
|
|
|
nm += strlen(COND_BASE);
|
|
_d("Reasserting %s => %s", fpath, nm);
|
|
cond_set(nm);
|
|
|
|
return 0;
|
|
}
|
|
|
|
/*
|
|
* Used only by netlink plugin atm.
|
|
* type: is a one of pid/, net/, etc.
|
|
*/
|
|
void cond_reassert(const char *type)
|
|
{
|
|
_d("%s", type);
|
|
nftw(cond_path(type), reassert, 20, FTW_DEPTH);
|
|
}
|
|
|
|
void cond_init(void)
|
|
{
|
|
char path[MAX_ARG_LEN];
|
|
|
|
if (mkpath(pid_runpath(_PATH_COND, path, sizeof(path)), 0755) && errno != EEXIST) {
|
|
_pe("Failed creating condition base directory '%s'", _PATH_COND);
|
|
return;
|
|
}
|
|
|
|
cond_bump_reconf();
|
|
}
|
|
|
|
/**
|
|
* Local Variables:
|
|
* indent-tabs-mode: t
|
|
* c-file-style: "linux"
|
|
* End:
|
|
*/
|