Joachim Wiberg
e5040385f5
Two races, both around the post:script Finit runs when it gives up on a service. Finit marks the service crashed before it forks post:script, so the file the test greps for lands a moment later. Waiting for the state is not enough. slay then takes the PID from initctl status, and service_post_script() sets svc->pid to the script's PID, so once Finit has given up the PID reported for the service is the post:script. Killing that takes out the script instead of the service and the file never arrives at all. The guard for this was already there, with a comment describing it, but inside the loop that waits for a PID to appear, so it only covered the case where there was none. A PID that was already there went straight to kill -9. Hence the gcc leg killing once more at lap 13, after Finit had stopped restarting, where clang stopped at 12. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Finit Test Suite
Finit comes with a set of tests and a small framework for running them. Contributors are encouraged to write new tests when implementing features, or fixing bugs.
Each test is run in isolation, in it's own namespace. Finit will therefore be able to be launched as PID 1. Since it's also running with it's own root directory it will be able to function properly without having any super user privileges in the host environment.
Running tests
To run the test suite, first build Finit, e.g:
./configure --prefix=/usr --exec-prefix= --sysconfdir=/etc --localstatedir=/var --enable-testserv-plugin
make -j9 clean all
Then run (parallel does not work atm):
make check
make check will set up the required assets for the test environment, and then
run the full set of tests. The environment is not removed afterwards so at
this point individual tests can be executed without having to run the entire
test suite, which is handy when developing new tests or debugging existing
test. To execute an individual test, simply invoke the script containing it:
./test/name-of-the-test.sh
Another way to run a single (or more) test(s) is to define the TESTS
environment variable:
TESTS="start-kill-service" make check