Add (failing) regression test for strtod locale TOCTOU bug
In debug builds, this test fails with `SIGABRT` due to an assertion. In release builds, truncation of the fractional part will be detected. Sometimes, this test may also cause memory violation (`SIGSEGV`) due to it being undefined behavior to set locale and use locale-dependent functions concurrently. On Windows, this does not happen since the global locale is protected by a mutex. This test assumes that a locale called "de_DE.UTF-8" exists on the host. If it does not, the test bails out but does not fail. The locale name is hard-coded because it is impossible to query available locales portably. "de_DE.UTF-8" is an accepted format on Ubuntu, macOS, and Windows. Signed-off-by: Jonas Greitemann <jgreitemann@gmail.com>
This commit is contained in:
1 parent
722c03495f
commit
0bc01a066c
2 files changed
+45
No files matched your search
@@ -121,6 +121,10 @@ json_test_set_test_options(test-disabled_exceptions
|
|||||||
# raise timeout of expensive Unicode test
|
# raise timeout of expensive Unicode test
|
||||||
json_test_set_test_options(test-unicode4 TEST_PROPERTIES TIMEOUT 3000)
|
json_test_set_test_options(test-unicode4 TEST_PROPERTIES TIMEOUT 3000)
|
||||||
|
|
||||||
|
# link pthreads to tests that need it
|
||||||
|
find_package(Threads REQUIRED)
|
||||||
|
json_test_set_test_options(test-regression2 LINK_LIBRARIES Threads::Threads)
|
||||||
|
|
||||||
#############################################################################
|
#############################################################################
|
||||||
# add unit tests
|
# add unit tests
|
||||||
#############################################################################
|
#############################################################################
|
||||||
|
|||||||
@@ -26,8 +26,11 @@ using ordered_json = nlohmann::ordered_json;
|
|||||||
using namespace nlohmann::literals; // NOLINT(google-build-using-namespace)
|
using namespace nlohmann::literals; // NOLINT(google-build-using-namespace)
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
|
#include <atomic>
|
||||||
|
#include <clocale>
|
||||||
#include <cstdio>
|
#include <cstdio>
|
||||||
#include <list>
|
#include <list>
|
||||||
|
#include <thread>
|
||||||
#include <type_traits>
|
#include <type_traits>
|
||||||
#include <utility>
|
#include <utility>
|
||||||
|
|
||||||
@@ -1239,6 +1242,44 @@ TEST_CASE("regression tests 2")
|
|||||||
CHECK(j == json({2, 4, 6}));
|
CHECK(j == json({2, 4, 6}));
|
||||||
}
|
}
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
|
SECTION("issue #5198 - TOCTOU race between lexer construction and locale changes causes float truncation")
|
||||||
|
{
|
||||||
|
std::atomic<bool> stop_requested{};
|
||||||
|
std::thread switcher([&stop_requested]
|
||||||
|
{
|
||||||
|
bool german = true;
|
||||||
|
const std::string initial_locale = std::setlocale(LC_NUMERIC, nullptr);
|
||||||
|
|
||||||
|
while (!stop_requested)
|
||||||
|
{
|
||||||
|
const bool setlocale_res = std::setlocale(LC_NUMERIC, german ? "de_DE.UTF-8" : "C");
|
||||||
|
WARN_MESSAGE(setlocale_res,
|
||||||
|
"Setting locale failed, probably because de_DE.UTF-8 is not installed. "
|
||||||
|
"This test was skipped as it would be inconclusive.");
|
||||||
|
if (!setlocale_res)
|
||||||
|
{
|
||||||
|
stop_requested = true;
|
||||||
|
}
|
||||||
|
german = !german;
|
||||||
|
}
|
||||||
|
|
||||||
|
(void)std::setlocale(LC_NUMERIC, initial_locale.c_str()); // restore original locale
|
||||||
|
});
|
||||||
|
|
||||||
|
for (std::size_t i = 0; i < 10000 && !stop_requested; ++i)
|
||||||
|
{
|
||||||
|
const json j = json::parse("{\"val\": 99.123456789}");
|
||||||
|
const double parsed = j.value("val", 0.0);
|
||||||
|
if (!CHECK(parsed == 99.123456789))
|
||||||
|
{
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
stop_requested = true;
|
||||||
|
switcher.join();
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
TEST_CASE_TEMPLATE("issue #4798 - nlohmann::json::to_msgpack() encode float NaN as double", T, double, float) // NOLINT(readability-math-missing-parentheses, bugprone-throwing-static-initialization)
|
TEST_CASE_TEMPLATE("issue #4798 - nlohmann::json::to_msgpack() encode float NaN as double", T, double, float) // NOLINT(readability-math-missing-parentheses, bugprone-throwing-static-initialization)
|
||||||
|
|||||||
Reference in new issue
Block a user