From 6be3f82b25f0c44d257a0f5dbf42ea417b4e850c Mon Sep 17 00:00:00 2001 From: Claude Date: Mon, 2 Nov 2026 12:32:29 +0000 Subject: [PATCH] Declare the value-initialized iterator in the test const clang-tidy (misc-const-correctness) flags it, as it is only compared. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01N5NasAgbDGG28MqXjQvLqp Signed-off-by: Claude --- tests/src/unit-diagnostic-positions.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/src/unit-diagnostic-positions.cpp b/tests/src/unit-diagnostic-positions.cpp index 6a36e5f7a..11f63fb59 100644 --- a/tests/src/unit-diagnostic-positions.cpp +++ b/tests/src/unit-diagnostic-positions.cpp @@ -249,7 +249,7 @@ TEST_CASE("comparing a value-initialized iterator throws invalid_iterator.212") // such an iterator has no value to take the byte positions from; the // comparison used to dereference the null pointer instead of throwing json j = {1, 2}; - json::iterator it{}; + const json::iterator it{}; CHECK_THROWS_WITH_AS(it == j.begin(), "[json.exception.invalid_iterator.212] cannot compare iterators of different containers", json::invalid_iterator); CHECK_THROWS_WITH_AS(it < j.begin(), "[json.exception.invalid_iterator.212] cannot compare iterators of different containers", json::invalid_iterator); CHECK_THROWS_WITH_AS(j.begin() == it, "[json.exception.invalid_iterator.212] cannot compare iterators of different containers", json::invalid_iterator);