From 755bb16d7a80436646380b5f871b93c6a443a3b7 Mon Sep 17 00:00:00 2001 From: Niels Lohmann Date: Fri, 30 Oct 2026 16:48:31 +0100 Subject: [PATCH] Fix the red CI on develop: remove the duplicate is_editable in basic_json_view (#5966) #5919 replaced the bool template parameter Editable of basic_json_view by view_mode Mode and defined is_editable from Mode. #5890 was written before that and added a second is_editable = Editable to the private section, which no longer compiles ("duplicate member", "undeclared identifier Editable"). It broke every job that builds the json_view tests (macOS, MSVC, clang-cl, clang on Windows, the C++20 module job, CodeQL). Signed-off-by: Niels Lohmann --- include/nlohmann/json_view.hpp | 3 --- single_include/nlohmann/json_view.hpp | 3 --- 2 files changed, 6 deletions(-) diff --git a/include/nlohmann/json_view.hpp b/include/nlohmann/json_view.hpp index 0c6c7410b..9d26d12ea 100644 --- a/include/nlohmann/json_view.hpp +++ b/include/nlohmann/json_view.hpp @@ -766,9 +766,6 @@ class basic_json_view template friend class detail::view::view_side; friend iterator; - /// whether the view is one of an editable document - static constexpr bool is_editable = Editable; - basic_json_view(const document_data* d, const node* n) noexcept : m_doc(d), m_node(n) {} diff --git a/single_include/nlohmann/json_view.hpp b/single_include/nlohmann/json_view.hpp index c4636da14..8ff21c77f 100644 --- a/single_include/nlohmann/json_view.hpp +++ b/single_include/nlohmann/json_view.hpp @@ -9807,9 +9807,6 @@ class basic_json_view template friend class detail::view::view_side; friend iterator; - /// whether the view is one of an editable document - static constexpr bool is_editable = Editable; - basic_json_view(const document_data* d, const node* n) noexcept : m_doc(d), m_node(n) {}