Merge branch 'claude/implement-5891-deff16' into claude/from-json-arith-array

Signed-off-by: Niels Lohmann <mail@nlohmann.me>

include/nlohmann/detail/input/json_sax.hpp

@@ -349,7 +349,7 @@ class json_sax_dom_error_state
         return false;
     }
 
-    constexpr bool is_errored() const
+    bool is_errored() const
     {
         return errored;
     }

include/nlohmann/detail/input/parser.hpp

@@ -168,7 +168,7 @@ class parser
             return finish_input(*sax, strict);
         }
 
-        return result;
+        return false;
     }
 
   private:

include/nlohmann/json.hpp

@@ -55,7 +55,7 @@
 #include <nlohmann/detail/abi_macros.hpp> // IWYU pragma: export
 #include <nlohmann/detail/conversions/from_json.hpp> // IWYU pragma: keep
 #include <nlohmann/detail/conversions/to_json.hpp> // IWYU pragma: keep
-#include <nlohmann/detail/exceptions.hpp>
+#include <nlohmann/detail/exceptions.hpp> // IWYU pragma: export
 #include <nlohmann/detail/hash.hpp>
 #include <nlohmann/detail/input/binary_reader.hpp>
 #include <nlohmann/detail/input/input_adapters.hpp>
@@ -3144,8 +3144,12 @@ public:
     {
         std::vector<std::uint8_t> result;
         result.reserve(detail::binary_initial_capacity(j));
-        auto writer = vector_writer(result, error_handler);
-        write(writer);
+        {
+            // the sink sets the size of result when it is destroyed, which
+            // must happen before result is returned (without NRVO, it is moved)
+            auto writer = vector_writer(result, error_handler);
+            write(writer);
+        }
         return result;
     }