From bdcfc178afd1cf73b34d681e184ae65b435b29d7 Mon Sep 17 00:00:00 2001
From: Niels Lohmann <mail@nlohmann.me>
Date: Mon, 26 Oct 2026 06:54:53 +0100
Subject: [PATCH] Fix clang-tidy findings in the json_view dump tests

Signed-off-by: Niels Lohmann <mail@nlohmann.me>
---
 tests/src/unit-json_view_dump.cpp        | 21 +++++++++++++++++++--
 tests/src/unit-json_view_dump_escape.cpp |  4 ----
 2 files changed, 19 insertions(+), 6 deletions(-)

diff --git a/tests/src/unit-json_view_dump.cpp b/tests/src/unit-json_view_dump.cpp
index 57c932a46..be1ec48ad 100644
--- a/tests/src/unit-json_view_dump.cpp
+++ b/tests/src/unit-json_view_dump.cpp
@@ -179,7 +179,24 @@ TEST_CASE("json_view dump")
                 digits.back() = static_cast<char>('0' + draw(10));
                 const std::size_t point = 1 + draw(9);
                 const std::string token = (draw(2) == 0 ? "-" : "") + digits.substr(0, point) + "." + digits.substr(point);
-                coordinates += (i != 0 ? "," : "") + (draw(8) == 0 ? "{\"x\":" + token + ",\"s\":\"a\"}" : "[" + token + "," + token + "]");
+                if (i != 0)
+                {
+                    coordinates += ',';
+                }
+                if (draw(8) == 0)
+                {
+                    coordinates += R"({"x":)";
+                    coordinates += token;
+                    coordinates += R"(,"s":"a"})";
+                }
+                else
+                {
+                    coordinates += '[';
+                    coordinates += token;
+                    coordinates += ',';
+                    coordinates += token;
+                    coordinates += ']';
+                }
             }
             coordinates += ",-65.613616999999977]";
             const json_document parsed = json_document::parse(coordinates);
@@ -194,7 +211,7 @@ TEST_CASE("json_view dump")
             {
                 const ordered_json& e = j[i++];
                 CHECK(v.dump() == e.dump());
-                if (v.is_array() && v.size() != 0 && v[0].is_number())
+                if (v.is_array() && !v.empty() && v[0].is_number())
                 {
                     CHECK(v[0].get<double>() == e[0].get<double>());
                 }
diff --git a/tests/src/unit-json_view_dump_escape.cpp b/tests/src/unit-json_view_dump_escape.cpp
index 4a80dcbd7..3def62df6 100644
--- a/tests/src/unit-json_view_dump_escape.cpp
+++ b/tests/src/unit-json_view_dump_escape.cpp
@@ -17,10 +17,6 @@ using nlohmann::json_view;
 using nlohmann::ordered_json_document;
 using nlohmann::ordered_json_view;
 
-#include "json_view_test_helpers.hpp"
-using json_view_test::generator;
-using json_view_test::has_duplicate_keys;
-
 #include <algorithm>
 #include <array>
 #include <cmath>