Niels Lohmann 4b027c9ea3 Fix to_msgpack() reading the inactive number union member ...

basic_json stores number_integer and number_unsigned in a union, and
number_unsigned_t only has to be at least as wide as number_integer_t
(with the default types, both are 64-bit and have the same
representation). When number_integer_t is narrower, write_msgpack()
read the wrong union member in two places:

- The number_unsigned case wrote number_integer's bits instead of
  number_unsigned's, silently writing the wrong value whenever it
  did not fit in number_integer_t.
- The number_integer case (non-negative branch) picked the encoded
  width by comparing number_unsigned's bits, which is undefined
  behavior, though the value written was still number_integer's, so
  at worst a too-wide encoding was chosen.

Read the active member in both cases, like the other binary writers
(CBOR, UBJSON, BJData, BSON, BON8) already do.

Fixes #5644.

Signed-off-by: Niels Lohmann <mail@nlohmann.me>

2026-09-29 23:38:43 +02:00

..

fuzzer-driver_afl.cpp

📄 adjust year (#5044)

2026-01-01 20:00:39 +01:00

fuzzer-parse_bjdata.cpp

Check the fuzzers' UBJSON/BJData round-trip invariants in the unit tests (#5569)

2026-09-25 08:29:02 +02:00

fuzzer-parse_bon8.cpp

Add BON8 support (#2998)

2026-09-27 16:56:21 +02:00

fuzzer-parse_bson.cpp

Refuse to build the fuzzer drivers with NDEBUG (#5562)

2026-09-24 17:02:57 +02:00

fuzzer-parse_cbor.cpp

Refuse to build the fuzzer drivers with NDEBUG (#5562)

2026-09-24 17:02:57 +02:00

fuzzer-parse_json.cpp

Refuse to build the fuzzer drivers with NDEBUG (#5562)

2026-09-24 17:02:57 +02:00

fuzzer-parse_msgpack.cpp

Refuse to build the fuzzer drivers with NDEBUG (#5562)

2026-09-24 17:02:57 +02:00

fuzzer-parse_ubjson.cpp

Check the fuzzers' UBJSON/BJData round-trip invariants in the unit tests (#5569)

2026-09-25 08:29:02 +02:00

make_test_data_available.hpp

📄 adjust year (#5044)

2026-01-01 20:00:39 +01:00

round_trip_corpus.hpp

Check the fuzzers' UBJSON/BJData round-trip invariants in the unit tests (#5569)

2026-09-25 08:29:02 +02:00

skip_library_version_check.cpp

Test suite: cover untested macro configs, std::formatter branches, patch_inplace, and fix a duplicate TEST_CASE name (#5492)

2026-09-16 20:15:46 +02:00

test_utils.hpp

Cut test suite runtime in binary roundtrips and integer sweeps (#5519)

2026-09-27 14:28:38 +02:00

unit-32bit.cpp

reject CBOR array/map length equal to the indefinite-length marker (#5274)

2026-07-31 18:04:30 +02:00

unit-algorithms.cpp

🔒 fix security findings (#5245)

2026-07-08 16:40:58 +02:00

unit-allocator.cpp

Add tests for uncovered code paths (#5581)

2026-09-27 14:19:22 +02:00

unit-alt-string.cpp

Add BON8 support (#2998)

2026-09-27 16:56:21 +02:00

unit-assert_macro.cpp

📄 adjust year (#5044)

2026-01-01 20:00:39 +01:00

unit-binary_formats.cpp

Add BON8 support (#2998)

2026-09-27 16:56:21 +02:00

unit-binary_writer_sinks.cpp

Add BON8 support (#2998)

2026-09-27 16:56:21 +02:00

unit-bjdata.cpp

Cut test suite runtime in binary roundtrips and integer sweeps (#5519)

2026-09-27 14:28:38 +02:00

unit-bon8.cpp

Add BON8 support (#2998)

2026-09-27 16:56:21 +02:00

unit-brace-init-copy-semantics.cpp

Test JSON_BRACE_INIT_COPY_SEMANTICS for real, and fix one-element tuples under it (#5544)

2026-09-24 17:05:37 +02:00

unit-bson.cpp

Add BON8 support (#2998)

2026-09-27 16:56:21 +02:00

unit-byte_container_with_subtype.cpp

Test suite: cover untested macro configs, std::formatter branches, patch_inplace, and fix a duplicate TEST_CASE name (#5492)

2026-09-16 20:15:46 +02:00

unit-capacity.cpp

📄 adjust year (#5044)

2026-01-01 20:00:39 +01:00

unit-cbor.cpp

Name the key type when rejecting non-string CBOR/MessagePack map keys (#5594)

2026-09-28 17:51:07 +02:00

unit-class_const_iterator.cpp

Add tests for uncovered code paths (#5581)

2026-09-27 14:19:22 +02:00

unit-class_iterator.cpp

📄 adjust year (#5044)

2026-01-01 20:00:39 +01:00

unit-class_lexer.cpp

Look up the locale decimal point at conversion time, not lexer construction (#5597)

2026-09-28 17:56:11 +02:00

unit-class_parser.cpp

Add BON8 support (#2998)

2026-09-27 16:56:21 +02:00

unit-comparison.cpp

Compare unordered objects by key below the nesting bound (#5582)

2026-09-27 14:21:58 +02:00

unit-concepts.cpp

📄 adjust year (#5044)

2026-01-01 20:00:39 +01:00

unit-constructor1.cpp

Fix #3868: Remove operator!= to enable P2468R2 rewritten candidate synthesis (#5253)

2026-07-09 20:38:39 +02:00

unit-constructor2.cpp

📄 adjust year (#5044)

2026-01-01 20:00:39 +01:00

unit-convenience.cpp

Stop dump() from heap-allocating its output adapter per call (#5449)

2026-09-11 08:22:50 +02:00

unit-conversions.cpp

Test suite: cover untested macro configs, std::formatter branches, patch_inplace, and fix a duplicate TEST_CASE name (#5492)

2026-09-16 20:15:46 +02:00

unit-custom-array-type.cpp

Support custom object/array types and improve template parameter handling (#5443)

2026-09-15 20:46:37 +02:00

unit-custom-base-class.cpp

📄 adjust year (#5044)

2026-01-01 20:00:39 +01:00

unit-custom-binary-type.cpp

Add BON8 support (#2998)

2026-09-27 16:56:21 +02:00

unit-custom-object-type.cpp

Add BON8 support (#2998)

2026-09-27 16:56:21 +02:00

unit-deserialization.cpp

Fix CI: resolve clang-tidy findings in the stream position tests (#5578)

2026-09-25 20:19:43 +02:00

unit-diagnostic-positions.cpp

Add tests for uncovered code paths (#5581)

2026-09-27 14:19:22 +02:00

unit-diagnostics.cpp

Keep JSON_DIAGNOSTICS parent pointers of ordered_json members after erase() and update() (#5552)

2026-09-25 08:29:36 +02:00

unit-disabled_exceptions.cpp

📄 adjust year (#5044)

2026-01-01 20:00:39 +01:00

unit-element_access1.cpp

📄 adjust year (#5044)

2026-01-01 20:00:39 +01:00

unit-element_access2.cpp

Add tests for uncovered code paths (#5581)

2026-09-27 14:19:22 +02:00

unit-explicit_instantiation.cpp

Add BON8 support (#2998)

2026-09-27 16:56:21 +02:00

unit-format-as.cpp

Add std::format and fmt support (#5224)

2026-07-02 15:59:36 +02:00

unit-hash.cpp

Hash deeply nested values without recursing per nesting level (#5546)

2026-09-24 17:12:02 +02:00

unit-inspection.cpp

📄 adjust year (#5044)

2026-01-01 20:00:39 +01:00

unit-items-cpp17.cpp

Reduce test-suite compile time: extract tiny per-standard test content; drop redundant legacy-comparison CI job (#5481)

2026-09-09 09:52:58 +02:00

unit-items.cpp

Reduce test-suite compile time: extract tiny per-standard test content; drop redundant legacy-comparison CI job (#5481)

2026-09-09 09:52:58 +02:00

unit-iterators1.cpp

📄 adjust year (#5044)

2026-01-01 20:00:39 +01:00

unit-iterators2.cpp

Fix #3868: Remove operator!= to enable P2468R2 rewritten candidate synthesis (#5253)

2026-07-09 20:38:39 +02:00

unit-iterators3.cpp

📄 adjust year (#5044)

2026-01-01 20:00:39 +01:00

unit-json_patch.cpp

Add tests for uncovered code paths (#5581)

2026-09-27 14:19:22 +02:00

unit-json_pointer.cpp

Add tests for uncovered code paths (#5581)

2026-09-27 14:19:22 +02:00

unit-large_json.cpp

Cut test suite runtime in binary roundtrips and integer sweeps (#5519)

2026-09-27 14:28:38 +02:00

unit-locale-cpp.cpp

Fix CI: clang-tidy and GCC -Wnoexcept in the locale test (#5613)

2026-09-28 22:20:43 +02:00

unit-merge_patch.cpp

Add tests for uncovered code paths (#5581)

2026-09-27 14:19:22 +02:00

unit-meta.cpp

📄 adjust year (#5044)

2026-01-01 20:00:39 +01:00

unit-modifiers.cpp

Fix CI: use VS 2026 on windows-11-arm and use raw string literals in tests (#5575)

2026-09-25 08:23:53 +02:00

unit-msgpack.cpp

Fix to_msgpack() reading the inactive number union member

2026-09-29 23:38:43 +02:00

unit-no_io_and_user_exceptions.cpp

Test suite: cover untested macro configs, std::formatter branches, patch_inplace, and fix a duplicate TEST_CASE name (#5492)

2026-09-16 20:15:46 +02:00

unit-no-macro-leak.cpp

Undefine the four JSON_HEDLEY_* macros that leak after including json.hpp (#5475)

2026-09-09 09:48:17 +02:00

unit-no-mem-leak-on-adl-serialize.cpp

Test suite: cover untested macro configs, std::formatter branches, patch_inplace, and fix a duplicate TEST_CASE name (#5492)

2026-09-16 20:15:46 +02:00

unit-noexcept.cpp

📄 adjust year (#5044)

2026-01-01 20:00:39 +01:00

unit-ordered_json2.cpp

Add BON8 support (#2998)

2026-09-27 16:56:21 +02:00

unit-ordered_json.cpp

Fix stack overflow when copying a deeply nested value (#5387) (#5389)

2026-09-24 17:01:15 +02:00

unit-ordered_map.cpp

Add missing overload to ordered_map::find (#5171)

2026-05-18 20:33:47 +02:00

unit-pointer_access.cpp

📄 adjust year (#5044)

2026-01-01 20:00:39 +01:00

unit-precise-stream-position.cpp

Add JSON_PRECISE_STREAM_POSITION to leave the character that terminates a number in the stream (#5344)

2026-09-25 17:56:18 +02:00

unit-readme.cpp

📄 adjust year (#5044)

2026-01-01 20:00:39 +01:00

unit-reference_access.cpp

📄 adjust year (#5044)

2026-01-01 20:00:39 +01:00

unit-regression1.cpp

Name the key type when rejecting non-string CBOR/MessagePack map keys (#5594)

2026-09-28 17:51:07 +02:00

unit-regression2.cpp

Add BON8 support (#2998)

2026-09-27 16:56:21 +02:00

unit-regression3.cpp

Add BON8 support (#2998)

2026-09-27 16:56:21 +02:00

unit-serialization.cpp

Add tests for uncovered code paths (#5581)

2026-09-27 14:19:22 +02:00

unit-std-format.cpp

Add tests for uncovered code paths (#5581)

2026-09-27 14:19:22 +02:00

unit-testsuites.cpp

📄 adjust year (#5044)

2026-01-01 20:00:39 +01:00

unit-to_chars.cpp

📄 adjust year (#5044)

2026-01-01 20:00:39 +01:00

unit-type_traits.cpp

avoid sign extension in char_traits<signed char>::to_int_type (#5336)

2026-08-03 08:35:53 +02:00

unit-ubjson.cpp

Cut test suite runtime in binary roundtrips and integer sweeps (#5519)

2026-09-27 14:28:38 +02:00

unit-udl.cpp

📄 adjust year (#5044)

2026-01-01 20:00:39 +01:00

unit-udt_macro.cpp

Support zero-member types in NLOHMANN_DEFINE_TYPE_* macros (#4041) (#5272)

2026-09-25 20:44:30 +02:00

unit-udt.cpp

📄 adjust year (#5044)

2026-01-01 20:00:39 +01:00

unit-unicode1.cpp

Broaden JSON_HEDLEY_WARN_UNUSED_RESULT coverage to pure query functions (#5477)

2026-09-09 09:50:39 +02:00

unit-unicode2.cpp

Broaden JSON_HEDLEY_WARN_UNUSED_RESULT coverage to pure query functions (#5477)

2026-09-09 09:50:39 +02:00

unit-unicode3.cpp

Fix dead ill-formed-fourth-byte UTF-8 test sections (byte3/byte4 typo) (#5499)

2026-09-16 20:16:43 +02:00

unit-unicode4.cpp

Fix dead ill-formed-fourth-byte UTF-8 test sections (byte3/byte4 typo) (#5499)

2026-09-16 20:16:43 +02:00

unit-unicode5.cpp

Fix dead ill-formed-fourth-byte UTF-8 test sections (byte3/byte4 typo) (#5499)

2026-09-16 20:16:43 +02:00

unit-user_defined_input.cpp

Speed up parsing of contiguous input (numbers, strings, UTF-8) (#5283)

2026-09-10 17:20:48 +02:00

unit-windows_h.cpp

📄 adjust year (#5044)

2026-01-01 20:00:39 +01:00

unit-wstring.cpp

Add tests for uncovered code paths (#5581)

2026-09-27 14:19:22 +02:00

unit.cpp

📄 adjust year (#5044)

2026-01-01 20:00:39 +01:00