* Add dump() and comparisons to json_view Add basic_json_view::dump() and the comparison operators, and read floats from the parser's digit layout instead of rescanning the token. dump(indent, indent_char, ensure_ascii, number_format) writes a value the way ordered_json::parse(text).dump() writes it for the same arguments: members in document order, all of them should a key occur more than once; strings escaped by the same rules, using the library's scanning kernels; floats written with the library's to_chars conversion, so the output equals basic_json's byte for byte; integers copied from the source, where they are already canonical, except -0, which parse() reads as 0. There is no error_handler argument, because the view only holds valid UTF-8. number_format::source copies numbers exactly as they appear in the source (e.g. "1.50", "1E2", "-0"), which basic_json cannot provide. operator<< takes the indentation from the stream width, as for basic_json. The writer walks iteratively, so nesting depth is limited by memory only. operator== and operator!= compare two views, or a view and a basic_json value in either order, by the rules basic_json's operator== uses: numbers compare by value across their types, objects compare by their members with duplicate keys resolved as parse() resolves them, member order matters only where the object type keeps one, and discarded views compare as discarded basic_json values do, including under JSON_USE_LEGACY_DISCARDED_VALUE_COMPARISON. Nothing is materialized except single scalars. While parsing, the view now records where the integer digits, the fraction digits, and the exponent of a float token are, so floats and doubles with at most 19 digits are read from that layout with the library's decimal_to_float() instead of rescanning the token. Both round correctly, so the values are those of parse(). get<double>(), materialize(), dump(), and the comparisons all use it. Signed-off-by: Niels Lohmann <mail@nlohmann.me> * Avoid raw string with escapes inside CHECK macro (MSVC C2017) Signed-off-by: Niels Lohmann <mail@nlohmann.me> * Size the dump buffer of a small value by its own extent The source extent of a value was read from the next node, falling back to the rest of the document when that node held a decoded string. dump() of a small value could thus allocate a buffer as large as the document. Skip a few such nodes, cap the fallback estimate, and shrink a buffer that is much larger than its output. Signed-off-by: Niels Lohmann <mail@nlohmann.me> * Hold the documents of the dump and comparison tests in names root() of a temporary document is deleted: its views would dangle. Signed-off-by: Niels Lohmann <mail@nlohmann.me> * Do not shrink the output of dump() finish() copied the whole output when the buffer was more than twice as large as the result (citm dump +11%). The tighter source_extent() estimate already keeps the buffer of a small value small. Signed-off-by: Niels Lohmann <mail@nlohmann.me> * Document and test first-wins lookups next to dump() and == dump() writes every member and == resolves duplicate keys as parse() does, whereas lookups find the first member of a duplicate key. Signed-off-by: Niels Lohmann <mail@nlohmann.me> * Fix the clang-tidy 22 findings in json_view and its tests Signed-off-by: Niels Lohmann <mail@nlohmann.me> * Split the dump and comparison tests off unit-json_view.cpp The MinGW linker of the Windows clang jobs cannot link object files with more than 32767 sections ("relocation truncated to fit: IMAGE_REL_AMD64_REL32 against `.rdata'"). unit-json_view.cpp reaches that limit as the stack grows, so its "json_view dump" and "json_view comparison" test cases move into unit-json_view_dump.cpp. The test generator and has_duplicate_keys() that both files use move into json_view_test_helpers.hpp. The new file mentions JSON_HAS_CPP_17, so it is built for C++17 like the file it was split from. Signed-off-by: Niels Lohmann <mail@nlohmann.me> * Make json_view.hpp pass include-what-you-use ci_single_binaries runs IWYU with --error on every header. For json_view.hpp it suggested adding <array> (std::array is used), the headers that json.hpp already provides (abi_config, abi_macros, input_adapters, json_pointer, cpp_future, string_concat, value_t, json_fwd), and <version> for std::nullptr_t, and removing <cstddef>. - include <array> - keep <cstddef> (nullptr_t, size_t; IWYU attributes them to <version> and <cstring>) - tell IWYU not to suggest the headers that json.hpp provides: the amalgamated json_view.hpp only includes json.hpp, so including them here would duplicate their definitions Signed-off-by: Niels Lohmann <mail@nlohmann.me> * Regenerate the amalgamated headers Signed-off-by: Niels Lohmann <mail@nlohmann.me> * Follow the renames from the review of the view builder The review of #5620 renamed document_data's tape/tape_size/tape_cap to nodes/node_count/node_capacity and made the decode arena a std::vector<char>; adapt the code of this change to it. Signed-off-by: Niels Lohmann <mail@nlohmann.me> * Keep the stream includes of json_view.hpp for IWYU json_view.hpp uses std::istream and std::ostream itself, but IWYU sees them through the exported json.hpp and asked to remove both includes, which fails ci_single_binaries (single_json_view). Signed-off-by: Niels Lohmann <mail@nlohmann.me> * Address the review of json_view dump() and comparisons From gregmarr's review of #5624: - The output buffer takes string literals without a length. - write_float() names the IEEE single/double condition once, as the library's serializer does. - equal() checks the types first and compares with !=; the reference to the top frame is noted as dangling after pop_back(). - dump.md: one paragraph per case in the notes. Signed-off-by: Niels Lohmann <mail@nlohmann.me> * Regenerate the amalgamated headers Signed-off-by: Niels Lohmann <mail@nlohmann.me> * Exclude all json_view test files from Infer's reports The same std::unique_ptr false positive (USE_AFTER_DELETE) also shows for two json_documents parsed in one lambda in unit-json_view_dump.cpp (ci_infer). It affects any test that holds several documents, so the exclusion now covers tests/src/unit-json_view*.cpp; ASan and Valgrind cover these tests. Signed-off-by: Niels Lohmann <mail@nlohmann.me> * Allow the string literal parameter of the view serializer's put() for clang-tidy The overload takes the literal by array reference so that its length is a template parameter, like scan_literal() and the C array overloads of to_json() and from_json(). Signed-off-by: Niels Lohmann <mail@nlohmann.me> * Bind the serializer's frame only after the check for its end Signed-off-by: Niels Lohmann <mail@nlohmann.me> * Regenerate the amalgamated headers Signed-off-by: Niels Lohmann <mail@nlohmann.me> --------- Signed-off-by: Niels Lohmann <mail@nlohmann.me>
Benchmarks
Micro-benchmarks for parsing, serialization and the binary formats, written with Google Benchmark. They are not run by CI; see When to run them.
What is measured
| benchmark | what it does |
|---|---|
ParseFile, ParseString |
parse JSON from a file stream or a string |
Accept |
validate JSON from a string (json::accept) |
ParseIndented |
parse the large files re-indented by 4 spaces, for the lexer's whitespace handling |
Dump |
serialize, compact (-) and indented (4) |
ToCbor, BinaryToCbor |
write CBOR; BinaryToCbor writes binary values of growing size |
FromMsgpack |
read MessagePack; unchanged over the years, so its numbers stay comparable across releases |
FromBinaryBuffer, FromBinaryFile |
read CBOR, MessagePack, UBJSON, BJData and BSON from a buffer or a FILE* |
FromBinaryShape |
read deeply nested, container-heavy and scalar-heavy documents in every binary format |
FromCborChunkedString |
read CBOR strings split into indefinite-length chunks |
ViewParse, ViewRead |
parse with json_document into a new document, or into one that is reused; compare with ParseString |
ViewParseIndented |
as ParseIndented, with a reused json_document |
ViewAccept |
validate with json_document::accept; compare with Accept |
ViewMaterialize |
convert a parsed json_document into a json value |
ViewDump |
serialize a parsed json_document; compare with Dump |
The input files are those of nativejson-benchmark (canada,
citm_catalog, twitter), a large jeopardy file, and number-heavy files (floats, signed_ints, ...).
bytes_per_second counts the bytes read or written: the JSON text when parsing, the output when serializing.
Requirements
- CMake 3.14 or later, a C++11 compiler, and Ninja for the
maketarget. - Network access on the first configure: CMake downloads Google Benchmark and the
test data into the build directory. To reuse a download of the test
data, pass
-DJSON_TestDataDirectory=<build directory>/test_files. - Google Benchmark is fetched as a fixed release with a checksum, so that every build uses the same
code and a download cannot change under you. It is updated like any other dependency when a new release comes out:
change
JSON_GOOGLE_BENCHMARK_VERSIONand the archive'sURL_HASHinCMakeLists.txttogether. Results are kept comparable by building both sides of a comparison with the same version, not by keeping that version forever (see Comparing two versions). - The benchmarks include
single_include/nlohmann/json.hpp, so runmake amalgamateafter changing anything ininclude/.
GCC and Clang builds use -O3 -flto -DNDEBUG.
Running them
From the repository root, this builds everything from scratch in cmake-build-benchmarks and runs all benchmarks:
make run_benchmarks
To build once and run selectively:
cmake -S tests/benchmarks -B build-benchmarks -G Ninja -DCMAKE_BUILD_TYPE=Release
cmake --build build-benchmarks
build-benchmarks/json_benchmarks --benchmark_filter='ParseString|Dump'
Useful options of json_benchmarks:
| option | effect |
|---|---|
--benchmark_list_tests |
list the benchmarks instead of running them |
--benchmark_filter=<regex> |
run only the benchmarks whose names match |
--benchmark_repetitions=<n> |
run every benchmark n times and add mean, median, standard deviation and coefficient of variation |
--benchmark_enable_random_interleaving=true |
run the repetitions in random order, which spreads out drifts such as thermal throttling |
--benchmark_min_time=<seconds>s |
run each benchmark at least this long (e.g. 2s) |
--benchmark_out=<file> --benchmark_out_format=json |
also write the results to a file, e.g. for compare.py |
Reading the output
Each line shows the wall-clock Time and the CPU time per iteration, the number of Iterations Google Benchmark
chose, and the throughput in bytes_per_second. With repetitions, the lines ending in _median are the ones to
compare. A _cv (coefficient of variation) above a few percent means the machine was too noisy for small
differences to mean anything.
Comparing two versions
To see what a change or a release did, build the same benchmarks twice: once against the header of the version to
compare with, and once against the current one. JSON_BENCHMARK_INCLUDE_DIR names the directory holding the
nlohmann/json.hpp to benchmark. For example, to compare the current checkout with 3.12.0:
# the header of the version to compare with
mkdir -p build-baseline-header/nlohmann
git show v3.12.0:single_include/nlohmann/json.hpp > build-baseline-header/nlohmann/json.hpp
# the same benchmarks, built against either header
cmake -S tests/benchmarks -B build-baseline -G Ninja -DCMAKE_BUILD_TYPE=Release \
-DJSON_BENCHMARK_INCLUDE_DIR="$PWD/build-baseline-header"
cmake -S tests/benchmarks -B build-current -G Ninja -DCMAKE_BUILD_TYPE=Release
cmake --build build-baseline
cmake --build build-current
# run both, back to back
build-baseline/json_benchmarks --benchmark_repetitions=10 --benchmark_enable_random_interleaving=true \
--benchmark_out=build-baseline/results.json --benchmark_out_format=json
build-current/json_benchmarks --benchmark_repetitions=10 --benchmark_enable_random_interleaving=true \
--benchmark_out=build-current/results.json --benchmark_out_format=json
Google Benchmark ships a tool to compare the two result files. It needs NumPy and SciPy:
python3 -m venv build-venv
build-venv/bin/pip install numpy scipy
build-venv/bin/python build-current/_deps/benchmark-src/tools/compare.py -a benchmarks build-baseline/results.json build-current/results.json
The tool's own tools/requirements.txt pins NumPy and SciPy versions that need Python 3.11 or later; with an older
Python, unpinned versions work as well. In its output:
- the
TimeandCPUcolumns are relative changes:-0.35means 35% faster,+0.10means 10% slower; _pvaluelines report a Mann-Whitney U test of whether the two versions differ. It needs at least 9 repetitions, and a p-value below 0.05 means the difference is unlikely to be noise;OVERALL_GEOMEANsummarizes all benchmarks;-ashows only the aggregates, not every repetition.
Both builds use the same Google Benchmark, the one CMakeLists.txt names, so only the header differs. For the same
reason, do not compare against result files from an earlier checkout: a different Google Benchmark, compiler or
machine state can shift the numbers as much as the change under test. Rerun the baseline instead.
The header you compare with must support everything the benchmarks use. The current benchmarks build against 3.12.0;
the View* benchmarks (in src/benchmarks_view.cpp) are only built if the directory also holds
nlohmann/json_view.hpp.
Only benchmarks present in both result files are compared, so for older releases, either filter the benchmarks or
build that release's own tests/benchmarks against its own header.
Getting stable numbers
- Build and run both versions on the same machine with the same compiler and Google Benchmark, one right after the other.
- Keep the machine otherwise idle: no builds, no browser, and a laptop plugged in.
- On Linux, set the CPU frequency governor to
performance, e.g.sudo cpupower frequency-set --governor performance. Google Benchmark prints a warning when frequency scaling is enabled. Pinning the process to a core (taskset -c 2 ...) helps as well. - Use 10 or more repetitions with random interleaving, compare medians, and treat changes within the
_cvas noise.
When to run them
They are a manual step, not part of CI: shared CI runners vary more between runs than most of the effects measured.
Run the comparison above before a release, comparing the previous release tag with develop, and for pull requests
that claim to change performance.