Report read errors from fsendfile()

fsendfile() returns the number of bytes copied when reading the source
fails, as if it had reached the end of the file.  It stops when fread()
returns nothing, without checking why.

Check ferror() on the source and return -1, with errno from the failed
read.

Closes #24
This commit is contained in:
omrzk authored and Joachim Wiberg committed 2026-11-16 14:13:06 +01:00
1 parent 798d70e2a2
commit 8befd09cf5
2 files changed
+42 -1

No files matched your search

+7 -1
View File
@@ -53,6 +53,7 @@ ssize_t fsendfile(FILE *src, FILE *dst, size_t len)
char *buf; char *buf;
size_t tot = 0; size_t tot = 0;
ssize_t blk = BUFSIZ, num = 0; ssize_t blk = BUFSIZ, num = 0;
int saved_errno;
if (!src) { if (!src) {
errno = EINVAL; errno = EINVAL;
@@ -68,8 +69,11 @@ ssize_t fsendfile(FILE *src, FILE *dst, size_t len)
blk = len - tot; blk = len - tot;
num = fread(buf, 1, blk, src); num = fread(buf, 1, blk, src);
if (num == 0) if (num == 0) {
if (ferror(src))
num = -1;
break; break;
}
if (dst && (fwrite(buf, num, 1, dst) != 1)) { if (dst && (fwrite(buf, num, 1, dst) != 1)) {
num = -1; num = -1;
@@ -79,7 +83,9 @@ ssize_t fsendfile(FILE *src, FILE *dst, size_t len)
tot += num; tot += num;
} }
saved_errno = errno;
free(buf); free(buf);
errno = saved_errno;
return (num == -1) ? -1 : (ssize_t)tot; return (num == -1) ? -1 : (ssize_t)tot;
} }
+35
View File
@@ -2,6 +2,39 @@
#include <unistd.h> #include <unistd.h>
#include "check.h" #include "check.h"
/* A failed read is an error, not EOF */
static void read_error(void)
{
int fd[2];
ssize_t rc;
FILE *src;
if (pipe(fd) || fcntl(fd[0], F_SETFL, O_NONBLOCK))
err(1, "Failed creating nonblocking pipe");
if (write(fd[1], "data", 4) != 4)
err(1, "Failed writing to pipe");
src = fdopen(fd[0], "r");
if (!src)
err(1, "Failed fdopen()");
printf("fsendfile(pipe, NULL, 4)\t");
rc = fsendfile(src, NULL, 4);
if (rc != 4)
errx(1, "Failed, got %zd, expected 4", rc);
printf("OK\n");
printf("fsendfile(empty pipe, NULL, 0)\t");
errno = 0;
rc = fsendfile(src, NULL, 0);
if (rc != -1 || errno != EAGAIN)
errx(1, "Failed, got %zd errno %d, expected -1 and EAGAIN", rc, errno);
printf("OK\n");
fclose(src);
close(fd[1]);
}
int main(void) int main(void)
{ {
int i = 0; int i = 0;
@@ -27,5 +60,7 @@ int main(void)
i += 2; i += 2;
} }
read_error();
return 0; return 0;
} }