With LITE_FOPT_RSYNC_LINKS, rsync() leaves symlinks in the destination.
If the source later has a regular file or a directory by the same name,
the next run follows the old link and writes to whatever it points at,
which can be outside the destination tree.
Remove such a link before copying.
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Fixing LITE_FOPT_COPYFILE_SYM in copyfile() also changed rsync(), which
has always passed that flag. Every caller would start getting links in
the destination where they used to get a copy of the file.
Keep following links by default and add LITE_FOPT_RSYNC_LINKS for
callers that want them recreated.
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Inspect source links without following them when COPYFILE_SYM is requested, before rejecting directories. This makes the documented option recreate link text instead of copying the referent, including dangling and directory links. Preserve requested link timestamps and report link-creation errors without overwriting the destination. Cover direct calls, destination directories, normal dereferencing and the existing rsync file caller.
Joachim Wiberg