From 9f3d892dcdf012c87cfec223648d751c26402a0e Mon Sep 17 00:00:00 2001 From: Otto Urpelainen Date: Wed, 21 Apr 2021 20:24:46 +0300 Subject: [PATCH] Remove CFLAGS from tests/Makefile.am Test are intended to be run from the root makefile, which delegates to tests subfolder. If tests define their own CFLAGS, any configuration from the root is overridden. This may result in a situation where the tests fail to execute, because the library was compiled with incompatible flags. In particular, the starard LDFLAGS used by Fedora are incompatible with the tests subfolder CFLAGS. Since there does not appear to be any particular reason for forcing the tests subfolder CFLAGS, they are removed here. --- tests/Makefile.am | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index d6bf898..72fdfb4 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -12,7 +12,5 @@ TESTS += event check_PROGRAMS = $(TESTS) -# Ignore warnings about unused result, in e.g. write() -CFLAGS = -W -Wall -Wextra -Wno-unused-result -Wno-unused-parameter CPPFLAGS = -D_GNU_SOURCE LDADD = -L../src ../src/libuev.la