diff --git a/TODO b/TODO index 0bd88dcf..f4a52084 100644 --- a/TODO +++ b/TODO @@ -9,13 +9,10 @@ Many, many things. Most notably: all directories under /proc/sys/dev/sensors with their SYSCTL id (needed for good sysctl access). * Write smbus_access_i2c in smbus.c -* Write piix4_* in piix4.c * Make lm78.c detect 'double hits', (same chip connected to both SMBus and ISA). * Better lm78/lm75 detection; insmod-time paramters to set addresses (difficult, because of all i2c busses!). -* Check whether some lm78 functionality is chip-generic and can be moved to - sensors.c. * Registrate which i2c addresses are used (a la ISA) for each adapter. * Rename i2c-proc.c to i2c-user.c, and extend it with /dev entries; or, create a better i2c-dev.c, that understands SMBus commands. diff --git a/kernel/chips/lm75.c b/kernel/chips/lm75.c index 18109c60..3d9cfdef 100644 --- a/kernel/chips/lm75.c +++ b/kernel/chips/lm75.c @@ -59,7 +59,7 @@ extern int cleanup_module(void); static int lm75_init(void); static int lm75_cleanup(void); static int lm75_attach_adapter(struct i2c_adapter *adapter); -int lm75_detach_client(struct i2c_client *client); +static int lm75_detach_client(struct i2c_client *client); static int lm75_command(struct i2c_client *client, unsigned int cmd, void *arg); static void lm75_inc_use (struct i2c_client *client); @@ -69,6 +69,7 @@ static int lm75_read_value(struct i2c_client *client, u8 reg); static int lm75_write_value(struct i2c_client *client, u8 reg, u16 value); static void lm75_temp(struct i2c_client *client, int operation, int ctl_name, int *nrels_mag, long *results); +static void lm75_update_client(struct i2c_client *client); /* This is the driver that will be inserted */ diff --git a/kernel/chips/lm78.c b/kernel/chips/lm78.c index 0beeebd7..95b34324 100644 --- a/kernel/chips/lm78.c +++ b/kernel/chips/lm78.c @@ -204,18 +204,18 @@ static void lm78_update_client(struct i2c_client *client); static void lm78_init_client(struct i2c_client *client); -void lm78_in(struct i2c_client *client, int operation, int ctl_name, - int *nrels_mag, long *results); -void lm78_fan(struct i2c_client *client, int operation, int ctl_name, - int *nrels_mag, long *results); -void lm78_temp(struct i2c_client *client, int operation, int ctl_name, - int *nrels_mag, long *results); -void lm78_vid(struct i2c_client *client, int operation, int ctl_name, - int *nrels_mag, long *results); -void lm78_alarms(struct i2c_client *client, int operation, int ctl_name, - int *nrels_mag, long *results); -void lm78_fan_div(struct i2c_client *client, int operation, int ctl_name, - int *nrels_mag, long *results); +static void lm78_in(struct i2c_client *client, int operation, int ctl_name, + int *nrels_mag, long *results); +static void lm78_fan(struct i2c_client *client, int operation, int ctl_name, + int *nrels_mag, long *results); +static void lm78_temp(struct i2c_client *client, int operation, int ctl_name, + int *nrels_mag, long *results); +static void lm78_vid(struct i2c_client *client, int operation, int ctl_name, + int *nrels_mag, long *results); +static void lm78_alarms(struct i2c_client *client, int operation, int ctl_name, + int *nrels_mag, long *results); +static void lm78_fan_div(struct i2c_client *client, int operation, int ctl_name, + int *nrels_mag, long *results); /* I choose here for semi-static LM78 allocation. Complete dynamic allocation could also be used; the code needed for this would probably diff --git a/src/lm75.c b/src/lm75.c index 18109c60..3d9cfdef 100644 --- a/src/lm75.c +++ b/src/lm75.c @@ -59,7 +59,7 @@ extern int cleanup_module(void); static int lm75_init(void); static int lm75_cleanup(void); static int lm75_attach_adapter(struct i2c_adapter *adapter); -int lm75_detach_client(struct i2c_client *client); +static int lm75_detach_client(struct i2c_client *client); static int lm75_command(struct i2c_client *client, unsigned int cmd, void *arg); static void lm75_inc_use (struct i2c_client *client); @@ -69,6 +69,7 @@ static int lm75_read_value(struct i2c_client *client, u8 reg); static int lm75_write_value(struct i2c_client *client, u8 reg, u16 value); static void lm75_temp(struct i2c_client *client, int operation, int ctl_name, int *nrels_mag, long *results); +static void lm75_update_client(struct i2c_client *client); /* This is the driver that will be inserted */ diff --git a/src/lm78.c b/src/lm78.c index 0beeebd7..95b34324 100644 --- a/src/lm78.c +++ b/src/lm78.c @@ -204,18 +204,18 @@ static void lm78_update_client(struct i2c_client *client); static void lm78_init_client(struct i2c_client *client); -void lm78_in(struct i2c_client *client, int operation, int ctl_name, - int *nrels_mag, long *results); -void lm78_fan(struct i2c_client *client, int operation, int ctl_name, - int *nrels_mag, long *results); -void lm78_temp(struct i2c_client *client, int operation, int ctl_name, - int *nrels_mag, long *results); -void lm78_vid(struct i2c_client *client, int operation, int ctl_name, - int *nrels_mag, long *results); -void lm78_alarms(struct i2c_client *client, int operation, int ctl_name, - int *nrels_mag, long *results); -void lm78_fan_div(struct i2c_client *client, int operation, int ctl_name, - int *nrels_mag, long *results); +static void lm78_in(struct i2c_client *client, int operation, int ctl_name, + int *nrels_mag, long *results); +static void lm78_fan(struct i2c_client *client, int operation, int ctl_name, + int *nrels_mag, long *results); +static void lm78_temp(struct i2c_client *client, int operation, int ctl_name, + int *nrels_mag, long *results); +static void lm78_vid(struct i2c_client *client, int operation, int ctl_name, + int *nrels_mag, long *results); +static void lm78_alarms(struct i2c_client *client, int operation, int ctl_name, + int *nrels_mag, long *results); +static void lm78_fan_div(struct i2c_client *client, int operation, int ctl_name, + int *nrels_mag, long *results); /* I choose here for semi-static LM78 allocation. Complete dynamic allocation could also be used; the code needed for this would probably