From 474d9b8bf17db0ba488c3cfd80d3c3f837aaa5d4 Mon Sep 17 00:00:00 2001
From: Jean Delvare <khali@linux-fr.org>
Date: Tue, 31 Aug 2004 18:53:01 +0000
Subject: [PATCH] Make it clear that the gl518sm "iterate" trick is gone in the
         Linux 2.6 driver (ticket #1767).

git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@2681 7894878c-1315-0410-8ee3-d5d059ff63e0
---
 doc/chips/gl518sm   |  7 +++++++
 etc/sensors.conf.eg | 12 +++++++++---
 2 files changed, 16 insertions(+), 3 deletions(-)

diff --git a/doc/chips/gl518sm b/doc/chips/gl518sm
index 67b0ba19..ec63b660 100644
--- a/doc/chips/gl518sm
+++ b/doc/chips/gl518sm
@@ -45,6 +45,10 @@ IMPORTANT: For the revision 0x00 chip, the
            unless you use the slow 'iterate' method. Limits will still
            work even when iterate=0. See below. This is a limitation
            of the chip, not the driver.
+           Note that the 'iterate' method was trimmed while porting the
+           driver to Linux 2.6 as we considered it too ugly for the thin
+           benefit.
+	   
 
 This driver supports the Genesys Logic GL518SM chip. There are at least
 two revision of this chip, which we call revision 0x00 and 0x80. Revision
@@ -112,6 +116,9 @@ You may also set the iteration type with
 If you have a rev 0x80 chip, the in0-in2 inputs are readable.
 In this case, 'iterate' will be read-only and the read value is 3.
 
+This does NOT apply to the Linux 2.6 kernel driver, where the 'iteration'
+code was dropped for being too ugly.
+
 
 Chip Features
 -------------
diff --git a/etc/sensors.conf.eg b/etc/sensors.conf.eg
index 346ee2cf..1d6d9ae8 100644
--- a/etc/sensors.conf.eg
+++ b/etc/sensors.conf.eg
@@ -786,7 +786,10 @@ chip "gl518sm-*"
 
 # IMPORTANT: in0, in1, and in2 values (+5, +3, and +12) CANNOT be read
 #            unless you use the slow 'iterate' method. Limits will still
-#            work even when iterate=0. See ../doc/chips/gl518sm.
+#            work even when iterate=0. See doc/chips/gl518sm.
+#            Note that the 'iterate' method was trimmed while porting the
+#            driver to Linux 2.6 as we considered it too ugly for the thin
+#            benefit.
 #
 # Factors and labels taken from GL518SM datasheet, they seem to give
 # reasonable values with EISCA connected Fan78
@@ -809,8 +812,11 @@ chip "gl518sm-*"
   set vin2_max 13.0
   set vin3_min 2.10
   set vin3_max 2.30
-  set fan1_off 0
-  set fan2_min 0
+#  set fan1_off 0
+#  set fan2_min 0
+
+# Do NOT uncomment the following line with the Linux 2.6 kernel driver,
+# as it'll raise an error.
 # set iterate 2