From 6be54c1d0912870268143b3b238b16f6ffedd7d6 Mon Sep 17 00:00:00 2001 From: Jean Delvare Date: Fri, 2 May 2008 10:10:34 +0000 Subject: [PATCH] High-byte first is not opposite to the usual practice - that's what almost all hardware monitoring drivers do. It is opposite to the SMBus standard though. Also delete a duplicate comment. (Backported from Linux 2.6) git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@5219 7894878c-1315-0410-8ee3-d5d059ff63e0 --- CHANGES | 1 + kernel/chips/lm75.c | 5 +---- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/CHANGES b/CHANGES index 7e69ee2c..422cef16 100644 --- a/CHANGES +++ b/CHANGES @@ -8,6 +8,7 @@ SVN-HEAD Module i2c-i801: Drop broken I2C block read support Module i2c-piix4: Minor cleanups (2.6 backport) Module i2c-sis5595: Minor cleanups (2.6 backport) + Module lm75: Fix an incorrect comment (2.6 backport) Program sensors-detect: New device ID for the SMSC SCH5317 Add SMSC SCH5127 detection Add National Semiconductor LM64 detection diff --git a/kernel/chips/lm75.c b/kernel/chips/lm75.c index 22562381..ee7f6038 100644 --- a/kernel/chips/lm75.c +++ b/kernel/chips/lm75.c @@ -233,7 +233,7 @@ static int lm75_detach_client(struct i2c_client *client) /* All registers are word-sized, except for the configuration register. LM75 uses a high-byte first convention, which is exactly opposite to - the usual practice. */ + the SMBus standard. */ static int lm75_read_value(struct i2c_client *client, u8 reg) { if (reg == LM75_REG_CONF) @@ -242,9 +242,6 @@ static int lm75_read_value(struct i2c_client *client, u8 reg) return swab16(i2c_smbus_read_word_data(client, reg)); } -/* All registers are word-sized, except for the configuration register. - LM75 uses a high-byte first convention, which is exactly opposite to - the usual practice. */ static int lm75_write_value(struct i2c_client *client, u8 reg, u16 value) { if (reg == LM75_REG_CONF)