From b5375e4344e8f8e6fa61f125205747d803dcdf02 Mon Sep 17 00:00:00 2001 From: Andre Prendel Date: Wed, 13 May 2009 16:07:50 +0000 Subject: [PATCH] sensord: Did some refactoring in parseChips(). This fixes some deep indentation levels. git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@5721 7894878c-1315-0410-8ee3-d5d059ff63e0 --- prog/sensord/args.c | 39 ++++++++++++++++++++------------------- 1 file changed, 20 insertions(+), 19 deletions(-) diff --git a/prog/sensord/args.c b/prog/sensord/args.c index 8c787d6d..d1a1d49b 100644 --- a/prog/sensord/args.c +++ b/prog/sensord/args.c @@ -231,33 +231,34 @@ int parseArgs(int argc, char **argv) int parseChips(int argc, char **argv) { - if (optind == argc) { + int i, n = argc - optind, err; + + if (n == 0) { sensord_args.chipNames[0].prefix = SENSORS_CHIP_NAME_PREFIX_ANY; sensord_args.chipNames[0].bus.type = SENSORS_BUS_TYPE_ANY; sensord_args.chipNames[0].bus.nr = SENSORS_BUS_NR_ANY; sensord_args.chipNames[0].addr = SENSORS_CHIP_NAME_ADDR_ANY; sensord_args.numChipNames = 1; - } else { - int i, n = argc - optind, err; - if (n > MAX_CHIP_NAMES) { - fprintf(stderr, "Too many chip names.\n"); + + return 0; + } + + if (n > MAX_CHIP_NAMES) { + fprintf(stderr, "Too many chip names.\n"); + return -1; + } + for (i = 0; i < n; ++i) { + char *arg = argv[optind + i]; + + err = sensors_parse_chip_name(arg, sensord_args.chipNames + i); + if (err) { + fprintf(stderr, "Invalid chip name `%s': %s\n", arg, + sensors_strerror(err)); return -1; } - for (i = 0; i < n; ++ i) { - char *arg = argv[optind + i]; - - err = sensors_parse_chip_name(arg, - sensord_args.chipNames + - i); - if (err) { - fprintf(stderr, - "Invalid chip name `%s': %s\n", arg, - sensors_strerror(err)); - return -1; - } - } - sensord_args.numChipNames = n; } + sensord_args.numChipNames = n; + return 0; }