Modern 4-pin fans can have a minimum speed (PWM=0) which is still
relatively high. I've seen 4500 RPM fans lower their speed to only
3500 RPM, which is 77% of the maximum speed, above our current
detection threshold (3/4 or 75%). Increase the threshold to 5/6
(roughly 83%) to make sure such fans are handled properly.
References: boo#1181890
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Systemd now wants PID files in /run, not /var/run. Service files have
been updated upstream already, but not the path used by the actual
programs. Change them too so that things don't break when the
/var/run symlink is eventually dropped.
References: bsc#1185183
These configurations would drive the PWM outputs in an "inverted mode"
where the 0 value is full fan speed and 255 stops the fan. The PWM
output adjustment algorithm works correctly in this situation.
If sensor doesn't return any value (in my case it happen when fan got broken - look below) whole script gets messed up. "cut" latter in the script assume there are more values in $GOODFAN then there are really and "cut -d' ' -f$count" doesn't return proper value.
root@yaro-desktop2:/sys/class/hwmon# cat hwmon0/fan1_input
cat: hwmon0/fan1_input: Bad argument
root@yaro-desktop2:/sys/class/hwmon#
The keywords Revision, Date and Id were being expanded by Subversion
way back when the project was being maintained in Subversion. Now when
the project is maintained in git, the keywords are no longer expanded
and appear e.g. in the output of sensors-detect literally.
Drop the keywords, or replace them with LM_SENSORS_VER where
applicable.
The value of the constant will have to be updated manually every time
a new release is made.
Inspired by a similar change in i2c-tools (commit daa430031ffd;
thanks, Jean).
Do command substitution in double quotes to prevent word splitting.
The issue was reported by Coverity Scan.
Signed-off-by: Ondřej Lysoněk <olysonek@redhat.com>
Update fancontrol script to save the values of pwmN_enable and pwmN
when it starts and restore the values, when it exits.
Closesgroeck/lm-sensors#47.
Signed-off-by: Roland Ramthun <bts@roland-ramthun.de>
[groeck: Split description into multiple lines]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Construct "wait $!" causes bash to remember the exit status of the
children. This consumes memory. We don't need the status code and we
are only waiting for a single child, so we can simply use "wait". This
will reduce the memory usage.
This partly fixes ticket #2391.
http://www.lm-sensors.org/ticket/2391
The actual leak is in bash 4.3 and should be fixed there.
The bug was introduced when I added support for multiple fans
controlled by the same PWM output, in r6000. lm-sensors versions
affected: 3.3.2 to 3.3.5.
This fixes SUSE bug #903520:
https://bugzilla.suse.com/show_bug.cgi?id=903520
Several kernel drivers have already moved their attributes from the
hardware device to the hwmon class device, and others will follow.
Teach fancontrol about this possibility and let it adjust the attribute
paths transparently.
Reported by Marc Ferland. Make DEVPATH and DEVNAME mandatory only when
using relative paths. Optionally support DEVNAME check when using
absolute paths.
When a given PWM output controls more than one fan,
fanactive_min is no longer a space-separated list of numbers, it will
also include items of the form "A+B". The tests in the rest of the
code do not expect that and choke with errors like:
/usr/sbin/pwmconfig: line 926: [: 538+799: integer expression expected
/usr/sbin/pwmconfig: line 952: [: 538+799: integer expression expected
As the only thing we really care about is whether any fan stops
completely when PWM is 0, we can simply record the minimum of the
lowest speed of all affected fans.
Detection threshold of 2/3 of the maximum speed is too low, some fans
will slow down to about that speed so controlled fans may be missed.
Use 3/4 as the threshold to avoid these false negatives.
Print the initial PWM values before letting the user change them. This
should be useful to better understand what happens next, and for user
support in general.
case where a given PWM output controls more than one fan, this makes
the script somewhat faster.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@5856 7894878c-1315-0410-8ee3-d5d059ff63e0
Jean Delvare