Commit Graph
59 Commits
Author SHA1 Message Date
Jean Delvare 8ddd1d2984 Save hwmon device paths and names in configuration file, and check them
before starting any fan control operation.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@5770 7894878c-1315-0410-8ee3-d5d059ff63e0
2009-09-16 15:57:53 +00:00
Jean Delvare bff5a8dde0 Clean up the code writing the configuration file.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@5767 7894878c-1315-0410-8ee3-d5d059ff63e0
2009-09-13 11:19:57 +00:00
Jean Delvare 6ff7f5e25b Exit immediately if not root.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@5749 7894878c-1315-0410-8ee3-d5d059ff63e0
2009-07-03 19:37:22 +00:00
Jean Delvare ea854deb03 Drop support for kernels 2.4 and earlier.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@5630 7894878c-1315-0410-8ee3-d5d059ff63e0
2009-01-29 08:28:17 +00:00
Jean Delvare 5f269d0f10 Don't choke on missing name attribute. Drivers shouldn't do that, but
we can live without the name attribute, so there's no point in failing.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5345 7894878c-1315-0410-8ee3-d5d059ff63e0
2008-09-28 15:22:44 +00:00
Jean Delvare f7ccb96a7c Add support for drivers that place the hwmon attributes in the hwmon
class device directory rather than directly in the device directory.
This is what virtual devices have.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5343 7894878c-1315-0410-8ee3-d5d059ff63e0
2008-09-27 15:35:47 +00:00
Jean Delvare 8f9a67f5bd Strip trailing whitespace.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5330 7894878c-1315-0410-8ee3-d5d059ff63e0
2008-09-09 16:18:27 +00:00
Jean Delvare 78e6d49180 Change default for MINTEMP from 0 to 20 degrees C. Computers never run at
below 20 degrees C, so setting MINTEMP to 0 uselessly reduces the control
range.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5329 7894878c-1315-0410-8ee3-d5d059ff63e0
2008-09-09 13:18:48 +00:00
Jean Delvare 012aae9b58 Skip MINSTOP and MINSTART tests if fan can't stop.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5328 7894878c-1315-0410-8ee3-d5d059ff63e0
2008-09-09 13:15:04 +00:00
Jean Delvare 346159764f Determine MINSTOP automatically.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5327 7894878c-1315-0410-8ee3-d5d059ff63e0
2008-09-09 12:14:28 +00:00
Jean Delvare c0645f4011 Detect and report obviously incorrect fan speeds.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5326 7894878c-1315-0410-8ee3-d5d059ff63e0
2008-09-09 09:30:38 +00:00
Jean Delvare 0277bca881 Print the revision and date at start-up.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5325 7894878c-1315-0410-8ee3-d5d059ff63e0
2008-09-09 07:26:51 +00:00
Jean Delvare 7ca1c39b92 Use the same step values for the MINSTOP test as we do for the detailed
correlation. That is, 15 above 31 and 2 below 31. This makes more sense
than using 10 all the time, as changes in low PWM values tend to have a
greater effect on fan speeds than changes in high PWM values.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5324 7894878c-1315-0410-8ee3-d5d059ff63e0
2008-09-08 13:51:22 +00:00
Jean Delvare 5f9008ddf3 Test MINSTOP before MINSTART. We know that MINSTART can't be less than
MINSTOP, so we can use MINSTOP as the initial value for the MINSTART test.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5323 7894878c-1315-0410-8ee3-d5d059ff63e0
2008-09-08 12:21:20 +00:00
Jean Delvare 01e44478ce Only mention gnuplot if X is running.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5322 7894878c-1315-0410-8ee3-d5d059ff63e0
2008-09-08 12:03:17 +00:00
Jean Delvare 38b2843d60 Add a utility function to filter configuration file variables.
Remove unneeded escapes. This makes the code slightly easier to read.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5321 7894878c-1315-0410-8ee3-d5d059ff63e0
2008-09-08 12:01:16 +00:00
Jean Delvare bf094bc123 Coding-style cleanups.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5320 7894878c-1315-0410-8ee3-d5d059ff63e0
2008-09-08 10:37:28 +00:00
Jean Delvare 1bf9b248b0 Fix MINSTOP and MINSTART test functions. PWM must be enabled for the duration
of the test, and disabled again afterwards. Bug reported by Philippe Roubach.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5318 7894878c-1315-0410-8ee3-d5d059ff63e0
2008-09-08 09:49:13 +00:00
Jean Delvare f9dbe31f15 Tell the user about gnuplot if isn't installed.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5317 7894878c-1315-0410-8ee3-d5d059ff63e0
2008-09-01 11:58:30 +00:00
Jean Delvare 17e7247f28 pwmconfig: Don't start if fancontrol is running.
fancontrol: Don't start if already running, delete fancontrol.pid at
exit time.
This closes ticket #2299.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5180 7894878c-1315-0410-8ee3-d5d059ff63e0
2008-04-16 14:29:01 +00:00
Jean Delvare be4ea8ac3e Don't create the configuration file before it's needed.
Don't preserve configuration file customizations.
Fix permissions of the configuration file.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5179 7894878c-1315-0410-8ee3-d5d059ff63e0
2008-04-16 11:18:36 +00:00
Jean Delvare f2e518511d Patch from Aurelien Jarno:
I have just noticed that the FSF address is the old one in all files
except COPYING. Please find a patch below to fix that.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5163 7894878c-1315-0410-8ee3-d5d059ff63e0
2008-03-26 13:37:12 +00:00
Jean Delvare 8f2142b76e Spelling fix.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5112 7894878c-1315-0410-8ee3-d5d059ff63e0
2008-01-27 14:18:24 +00:00
Jean Delvare 04ae8141b8 MINPWM and MAXPWM may be undefined for a given PWM output.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5111 7894878c-1315-0410-8ee3-d5d059ff63e0
2008-01-27 12:36:28 +00:00
Jean Delvare 3914365547 Fix duplicate warning message when configuration file is broken.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5103 7894878c-1315-0410-8ee3-d5d059ff63e0
2008-01-09 11:01:44 +00:00
Jean Delvare e6c94c66ed Bash doesn't do lazy evaluation on test-like expressions, so don't
assume it does (#2292).


git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5100 7894878c-1315-0410-8ee3-d5d059ff63e0
2008-01-08 20:10:52 +00:00
Jean Delvare 936c5f66c2 Switch to SVN revision numbering, so that the version is always up-to-date.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5099 7894878c-1315-0410-8ee3-d5d059ff63e0
2008-01-08 19:12:44 +00:00
Jean Delvare 7963e7cf13 Repeat available configuration options before prompt (#2289).
The code isn't very clean but that's the best I could come up with.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5098 7894878c-1315-0410-8ee3-d5d059ff63e0
2008-01-08 19:02:40 +00:00
Jean Delvare 9bf2d8c187 Warn about outputs found in automatic mode.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5063 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-12-04 10:21:16 +00:00
Jean Delvare 972e5e2f01 Really hide errors on sysfs writes.
Deal gracefully with read-only pwm_enable files.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5061 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-12-04 09:27:49 +00:00
Jean Delvare c0637bebe0 pwmconfig: Give the fans some time to spin up.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5025 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-11-18 16:16:41 +00:00
Jean Delvare a95f194cef pwmconfig: Better diagnostics in pwmdisable.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@5023 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-11-18 16:01:04 +00:00
Jean Delvare 855b1aa6ef The lm-sensors team has no legal existence and thus can't hold a copyright.
I tried to assign the copyright back to the original author where possible.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@4900 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-09-29 19:08:30 +00:00
Jean Delvare fe165fea49 Fix error message.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@4692 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-08-21 09:08:52 +00:00
Jean Delvare 57044be111 fancontrol:
* Check for configuration file validity
fancontrol and pwmconfig:
* Support optional min and max PWM values
Documentation updated accordingly.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@4442 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-06-12 11:37:19 +00:00
Jean Delvare d10c5f218b pwmconfig: Use smaller steps for low PWM values. Inspired from a patch
from the openSuse sensors package. This is a good idea because the
PWM/speed relation isn't linear, and it is frequent that the speed
changes are concentrated in the low PWM range.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0@4381 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-04-27 13:41:32 +00:00
Jean Delvare 63228c12b3 Strip unneeded whitespace on configuration load.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@4296 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-01-14 15:42:33 +00:00
Jean Delvare 2387b4cd73 Drop commented out code.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@4288 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-01-09 07:58:52 +00:00
Jean Delvare b162d642a9 pwmconfig, fancontrol: Add support for non-i2c drivers. So far the
scripts were assuming that all drivers were i2c-based. As we want to
get rid of i2c-isa in Linux 2.6 soon, it's important to ensure that
platform drivers are handled properly.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@4286 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-01-07 22:10:02 +00:00
Jean Delvare 55e8649c0d pwmconfig, fancontrol: Gracefully handle errors when writing to
sysfs files, as bash 3.1 otherwise displays them and this tends to
frighten the user.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@4280 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-01-05 16:34:32 +00:00
Jean Delvare 5ff0a6b0e7 Use mktemp instead of tempfile to create the temporary config file.
We are already using mktemp elsewhere in the script, and it seems to be
more widely available than tempfile.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@4153 7894878c-1315-0410-8ee3-d5d059ff63e0
2006-09-07 15:56:11 +00:00
Jean Delvare 28f8be1038 Drop all references to the old mailing list.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@3075 7894878c-1315-0410-8ee3-d5d059ff63e0
2005-09-08 16:29:41 +00:00
Rudolf Marek 8894546f1f Fix potentional security issue. Thanks to Javier Fernández-Sanguino Peña <jfs@computer.org>
git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@3060 7894878c-1315-0410-8ee3-d5d059ff63e0
2005-08-20 19:45:53 +00:00
Mark D. Studebaker 57782cede2 fix handling of alternate config file name
git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@2930 7894878c-1315-0410-8ee3-d5d059ff63e0
2005-03-15 19:24:25 +00:00
Mark D. Studebaker 78f5390e51 allow readonly pwmx_enable files (lm85 kernel 2.6)
tickets 1874, 1879


git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@2883 7894878c-1315-0410-8ee3-d5d059ff63e0
2005-01-29 23:04:25 +00:00
Jean Delvare a0a471c8c5 *** SECURITY FIX ***
Secure the creation of temporary files. Problem found by Javier
Fernandez-Sanguino Pena, patch by Aurelien Jarno.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@2871 7894878c-1315-0410-8ee3-d5d059ff63e0
2005-01-26 21:12:50 +00:00
Jean Delvare cb64b74141 Handle both pwm files naming scheme for 2.6 kernels (ticket
#1844).


git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@2798 7894878c-1315-0410-8ee3-d5d059ff63e0
2004-12-20 22:00:10 +00:00
Jean Delvare 08091f09b2 Fix typo. Reported by Rutger Nijlunsing.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@2520 7894878c-1315-0410-8ee3-d5d059ff63e0
2004-05-09 17:27:55 +00:00
Jean Delvare 12e4bc4853 Follow new sysfs naming scheme.
git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@2514 7894878c-1315-0410-8ee3-d5d059ff63e0
2004-05-08 19:38:20 +00:00
Jean Delvare f032b85a9d Use new sysfs file name conventions. Suggested by Rutger
Nijlunsing.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@2510 7894878c-1315-0410-8ee3-d5d059ff63e0
2004-05-08 11:33:47 +00:00