Commit Graph
5 Commits
Author SHA1 Message Date
Jean Delvare 567c1e3e3a i2c-ali1563: Fix device initialization (backported from Linux 2.6)
The i2c-ali1563 initialization looks quite broken to me:
* If the I/O space isn't enabled, we forcibly set 3 bits in
  the PCI configuration space instead of just the one enabling
  the I/O space.
* After that we pretend to check if the write worked, but we
  don't actually read the new value from the register.
* It's probably not a good idea to enable the I/O space if no
  base address has been set.

So I propose the following changes to that part of the driver:
* Merge ali1563_enable() into ali1563_setup().
* Check the base address before the I/O space enabled bit.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@4324 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-02-15 10:42:43 +00:00
Jean Delvare 529b3a0d08 Improve the status messages printed by the i2c-ali1563 driver.
This is a backport from Linux 2.6.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@4323 7894878c-1315-0410-8ee3-d5d059ff63e0
2007-02-15 10:36:29 +00:00
Jean Delvare 7f68d835a3 Backport from Linux 2.6:
Clean up name string usage in 11 i2c bus drivers:
* Use the pci_driver name for requesting the I/O region rather than
  redefining a new string.
* Do not initialize the i2c_adapter name to "unset".
This should save a few data bytes here and there.


git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@3149 7894878c-1315-0410-8ee3-d5d059ff63e0
2005-10-30 10:02:58 +00:00
Mark D. Studebaker f876b23490 remove Chunhao's email addr at his request (no longer valid)
git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@3029 7894878c-1315-0410-8ee3-d5d059ff63e0
2005-06-28 03:49:19 +00:00
Mark D. Studebaker e74dbb2dbb Backport from 2.6 by Chunhao Huang/Winbond as recvd 4/8/05
git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@2971 7894878c-1315-0410-8ee3-d5d059ff63e0
2005-04-14 15:24:28 +00:00