mirror of
https://github.com/lm-sensors/lm-sensors.git
synced 2026-10-15 10:39:31 +00:00
Mark M. Hoffman
71a96916d5
> Current gcc versions warn when type punning is used, as this breaks the > strict aliasing analysis gcc 3.3 does by default. When checking the causes > for these warnings I discovered that sensors_malloc_array, > sensors_free_array, sensors_add_array_el and sensors_add_array_els in > lib/general.c all take a 'void **' for the list. This is plain wrong as > the C standard only allow 'char *' and 'void *' to alias any other type, so > if these functions should take a generic pointer, it *must* be a 'void *' > that's internally cast to a 'void **'. > > The attached patch does this and adapts all places where these functions are > called. Note that when done correctly, no cast what-so-ever in the calling > code is needed. > > The patch is against current lm_sensors2 cvs version. git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@2345 7894878c-1315-0410-8ee3-d5d059ff63e0
40 lines
1.8 KiB
C
40 lines
1.8 KiB
C
/*
|
|
general.h - Part of libsensors, a Linux library for reading sensor data.
|
|
Copyright (c) 1998, 1999 Frodo Looijaard <frodol@dds.nl>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
|
|
*/
|
|
|
|
#ifndef LIB_SENSORS_GENERAL
|
|
#define LIB_SENSORS_GENERAL
|
|
|
|
/* These are general purpose functions. They allow you to use variable-
|
|
length arrays, which are extended automatically. A distinction is
|
|
made between the current number of elements and the maximum number.
|
|
You can only add elements at the end. Primitive, but very useful
|
|
for internal use. */
|
|
extern void sensors_malloc_array(void *list, int *num_el, int *max_el,
|
|
int el_size);
|
|
extern void sensors_free_array(void *list, int *num_el, int *max_el);
|
|
extern void sensors_add_array_el(const void *el, void *list, int *num_el,
|
|
int *max_el, int el_size);
|
|
extern void sensors_add_array_els(const void *els, int nr_els, void *list,
|
|
int *num_el, int *max_el, int el_size);
|
|
|
|
/* Strip a string of all terminating spaces */
|
|
extern void sensors_strip_of_spaces(char *name);
|
|
|
|
#endif /* LIB_SENSORS_GENERAL */
|